refactor: move doc-title and ai-chat-block components #10316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Saul-Mirone
force-pushed
the
02-20-refactor_editor_improve_code_structure_of_ai_chat_block
branch
from
4e4bfca to
713ca1c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #10316 +/- ##
==========================================
+ Coverage 54.25% 54.28% +0.02%
==========================================
Files 2338 2335 -3
Lines 108101 108072 -29
Branches 17862 17859 -3
==========================================
+ Hits 58650 58662 +12
+ Misses 48128 48080 -48
- Partials 1323 1330 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Saul-Mirone
force-pushed
the
02-20-refactor_editor_improve_code_structure_of_ai_chat_block
branch
2 times, most recently
from
440d22a to
e07ee73
Compare
doodlewind
approved these changes
Feb 20, 2025
Saul-Mirone
force-pushed
the
02-20-refactor_editor_improve_code_structure_of_ai_chat_block
branch
from
e07ee73 to
868540b
Compare
Saul-Mirone
changed the title
Saul-Mirone
force-pushed
the
02-20-refactor_editor_improve_code_structure_of_ai_chat_block
branch
from
868540b to
8604c4f
Compare
Merge activity
|
### TL;DR Moved doc title and AI chat block components to more appropriate locations while removing unused backlink functionality. ### What changed? - Relocated doc title component from presets to affine-components - Moved AI chat block from presets/blocks to blocks directory - Removed unused backlink-related code and components - Updated imports across files to reference new component locations - Consolidated AI-related exports through a single entry point ### How to test? 1. Verify doc title still renders correctly in documents 2. Confirm AI chat functionality works as expected 3. Check that no backlink-related features are accessible 4. Ensure all AI features continue to work through the new import paths ### Why make this change? This reorganization improves code organization by: - Placing components closer to their related functionality - Removing dead/unused code around backlinks - Simplifying the import structure for AI-related features - Making the codebase more maintainable by consolidating related components
graphite-app
bot
force-pushed
the
02-20-refactor_editor_improve_code_structure_of_ai_chat_block
branch
from
8604c4f to
1516903
Compare
graphite-app
bot
deleted the
02-20-refactor_editor_improve_code_structure_of_ai_chat_block
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Moved doc title and AI chat block components to more appropriate locations while removing unused backlink functionality.
What changed?
How to test?
Why make this change?
This reorganization improves code organization by: