Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): settings storage empty styles #10313

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Feb 20, 2025

fix PD-2339

@pengx17 pengx17 marked this pull request as ready for review February 20, 2025 08:40
Copy link
Collaborator Author

pengx17 commented Feb 20, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app graphite-app bot requested review from a team February 20, 2025 08:40
@pengx17 pengx17 force-pushed the 02-20-fix_core_settings_storage_empty_styles branch from b6bb0d9 to e140f5d Compare February 20, 2025 08:41
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.24%. Comparing base (5fcc402) to head (e140f5d).
Report is 26 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary   #10313      +/-   ##
==========================================
- Coverage   54.50%   54.24%   -0.26%     
==========================================
  Files        2338     2338              
  Lines      108107   108107              
  Branches    17905    17863      -42     
==========================================
- Hits        58927    58647     -280     
- Misses      47854    48137     +283     
+ Partials     1326     1323       -3     
Flag Coverage Δ
server-test 78.60% <ø> (-0.68%) ⬇️
unittest 31.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forehalo forehalo merged commit 83669f8 into canary Feb 21, 2025
66 checks passed
@forehalo forehalo deleted the 02-20-fix_core_settings_storage_empty_styles branch February 21, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants