Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): remove job on complete #10305

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Feb 20, 2025

No description provided.

Copy link
Member Author

fengmk2 commented Feb 20, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fengmk2 fengmk2 requested review from darkskygit, forehalo and a team February 20, 2025 03:59
@fengmk2 fengmk2 marked this pull request as ready for review February 20, 2025 04:00
@graphite-app graphite-app bot requested a review from a team February 20, 2025 04:00
@forehalo forehalo changed the title fix(server): remove job on complete y Feb 20, 2025
@forehalo forehalo changed the title y fix(server): remove job on complete Feb 20, 2025
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.12%. Comparing base (5042d9f) to head (ff0ce1a).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@           Coverage Diff           @@
##           canary   #10305   +/-   ##
=======================================
  Coverage   54.12%   54.12%           
=======================================
  Files        2334     2334           
  Lines      107817   107815    -2     
  Branches    17816    17818    +2     
=======================================
- Hits        58351    58350    -1     
+ Misses      48142    48134    -8     
- Partials     1324     1331    +7     
Flag Coverage Δ
server-test 78.39% <100.00%> (+<0.01%) ⬆️
unittest 31.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Feb 20, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 02-20-fix_server_remove_job_on_complete branch from 6437a4b to ff0ce1a Compare February 20, 2025 04:39
@graphite-app graphite-app bot merged commit ff0ce1a into canary Feb 20, 2025
66 checks passed
@graphite-app graphite-app bot deleted the 02-20-fix_server_remove_job_on_complete branch February 20, 2025 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants