Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(server): move bin content parser to doc reader #10302

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Feb 20, 2025

No description provided.

@github-actions github-actions bot added app:server test Related to test cases labels Feb 20, 2025
Copy link
Member Author

fengmk2 commented Feb 20, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 88.40580% with 24 lines in your changes missing coverage. Please review.

Project coverage is 54.12%. Comparing base (9f4311f) to head (b4097ae).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
packages/backend/server/src/core/doc/reader.ts 86.36% 21 Missing ⚠️
...backend/server/src/core/doc-renderer/controller.ts 66.66% 1 Missing ⚠️
packages/backend/server/src/core/doc/event.ts 94.11% 0 Missing and 1 partial ⚠️
...nd/server/src/core/workspaces/resolvers/service.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           canary   #10302   +/-   ##
=======================================
  Coverage   54.11%   54.12%           
=======================================
  Files        2335     2334    -1     
  Lines      107862   107929   +67     
  Branches    17827    17843   +16     
=======================================
+ Hits        58374    58420   +46     
- Misses      48166    48191   +25     
+ Partials     1322     1318    -4     
Flag Coverage Δ
server-test 78.47% <87.92%> (+0.08%) ⬆️
unittest 31.20% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fengmk2 fengmk2 force-pushed the 02-20-refactor_server_move_bin_content_parser_to_doc_reader branch 4 times, most recently from a1b4686 to 1c3014e Compare February 20, 2025 06:17
@fengmk2 fengmk2 requested review from forehalo and a team February 20, 2025 06:18
@fengmk2 fengmk2 marked this pull request as ready for review February 20, 2025 06:18
@graphite-app graphite-app bot requested a review from a team February 20, 2025 06:18
@fengmk2 fengmk2 force-pushed the 02-20-refactor_server_move_bin_content_parser_to_doc_reader branch 3 times, most recently from 35aa731 to 91e842e Compare February 20, 2025 06:58
Copy link

graphite-app bot commented Feb 20, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 02-20-refactor_server_move_bin_content_parser_to_doc_reader branch from 91e842e to b4097ae Compare February 20, 2025 07:19
@graphite-app graphite-app bot merged commit b4097ae into canary Feb 20, 2025
66 checks passed
@graphite-app graphite-app bot deleted the 02-20-refactor_server_move_bin_content_parser_to_doc_reader branch February 20, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:server test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants