Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): paste surface-ref block to another doc as embed-linked-doc block #10274

Conversation

donteatfriedrice
Copy link
Member

@donteatfriedrice donteatfriedrice commented Feb 19, 2025

@github-actions github-actions bot added the test Related to test cases label Feb 19, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@donteatfriedrice donteatfriedrice marked this pull request as ready for review February 19, 2025 05:55
@donteatfriedrice donteatfriedrice requested a review from a team as a code owner February 19, 2025 05:55
@graphite-app graphite-app bot requested review from a team February 19, 2025 05:55
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.21%. Comparing base (751f229) to head (319d909).
Report is 2 commits behind head on canary.

Files with missing lines Patch % Lines
...d/src/adapters/middlewares/surface-ref-to-embed.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary   #10274      +/-   ##
==========================================
+ Coverage   54.18%   54.21%   +0.03%     
==========================================
  Files        2334     2334              
  Lines      107706   107711       +5     
  Branches    17802    17801       -1     
==========================================
+ Hits        58358    58400      +42     
+ Misses      48025    47977      -48     
- Partials     1323     1334      +11     
Flag Coverage Δ
server-test 78.44% <ø> (ø)
unittest 31.39% <90.90%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@donteatfriedrice donteatfriedrice force-pushed the 02-19-fix_editor_paste_surface-ref_block_to_another_doc_as_embed-linked-doc_block branch from 81b217e to bfaef2a Compare February 19, 2025 06:17
Copy link
Contributor

@Saul-Mirone Saul-Mirone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

graphite-app bot commented Feb 19, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 02-19-fix_editor_paste_surface-ref_block_to_another_doc_as_embed-linked-doc_block branch from aabd029 to 319d909 Compare February 19, 2025 07:02
@graphite-app graphite-app bot merged commit 319d909 into canary Feb 19, 2025
66 checks passed
@graphite-app graphite-app bot deleted the 02-19-fix_editor_paste_surface-ref_block_to_another_doc_as_embed-linked-doc_block branch February 19, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants