Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dnd database preview block #10258

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

doouding
Copy link
Member

No description provided.

@doouding doouding marked this pull request as ready for review February 18, 2025 09:34
@doouding doouding requested a review from a team as a code owner February 18, 2025 09:34
@graphite-app graphite-app bot requested review from a team February 18, 2025 09:34
Copy link
Member Author

doouding commented Feb 18, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@doouding doouding force-pushed the 02-18-feat_add_dnd_database_preview_block branch from 177af6a to 7105417 Compare February 18, 2025 09:39
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 54.22%. Comparing base (75678ce) to head (c21f71f).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...e/widget-drag-handle/src/helpers/preview-helper.ts 0.00% 2 Missing ⚠️
...e/block-database/src/database-dnd-preview-block.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary   #10258      +/-   ##
==========================================
+ Coverage   54.18%   54.22%   +0.03%     
==========================================
  Files        2332     2333       +1     
  Lines      107662   107667       +5     
  Branches    17793    17795       +2     
==========================================
+ Hits        58337    58381      +44     
+ Misses      48007    47960      -47     
- Partials     1318     1326       +8     
Flag Coverage Δ
server-test 78.43% <ø> (+0.01%) ⬆️
unittest 31.40% <40.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Feb 18, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 02-18-fix_allow_to_drop_inside_the_note_block_in_edgeless_mode branch from 9e2ec50 to 75678ce Compare February 18, 2025 10:25
@graphite-app graphite-app bot force-pushed the 02-18-feat_add_dnd_database_preview_block branch from 7105417 to c21f71f Compare February 18, 2025 10:25
Base automatically changed from 02-18-fix_allow_to_drop_inside_the_note_block_in_edgeless_mode to canary February 18, 2025 10:41
@graphite-app graphite-app bot merged commit c21f71f into canary Feb 18, 2025
66 checks passed
@graphite-app graphite-app bot deleted the 02-18-feat_add_dnd_database_preview_block branch February 18, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants