Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(editor): remove page block feature flag #10251

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

L-Sun
Copy link
Contributor

@L-Sun L-Sun commented Feb 18, 2025

No description provided.

Copy link
Contributor Author

L-Sun commented Feb 18, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@L-Sun L-Sun marked this pull request as ready for review February 18, 2025 08:26
@github-actions github-actions bot added mod:i18n Related to i18n app:core labels Feb 18, 2025
@L-Sun L-Sun requested a review from a team as a code owner February 18, 2025 08:26
@graphite-app graphite-app bot requested review from a team February 18, 2025 08:26
@L-Sun L-Sun changed the title chore(editor): remove page block feature flags chore(editor): remove page block feature flag Feb 18, 2025
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.21%. Comparing base (cedee0a) to head (e639f08).
Report is 2 commits behind head on canary.

Additional details and impacted files
@@           Coverage Diff           @@
##           canary   #10251   +/-   ##
=======================================
  Coverage   54.20%   54.21%           
=======================================
  Files        2337     2336    -1     
  Lines      107677   107676    -1     
  Branches    17796    17799    +3     
=======================================
+ Hits        58366    58372    +6     
+ Misses      47985    47978    -7     
  Partials     1326     1326           
Flag Coverage Δ
server-test 78.42% <ø> (ø)
unittest 31.40% <40.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@L-Sun L-Sun force-pushed the l-sun/chore/remove-feature-flags branch 2 times, most recently from 918f6b0 to 9a3323f Compare February 18, 2025 09:04
Copy link

graphite-app bot commented Feb 18, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the l-sun/chore/remove-feature-flags branch from 9a3323f to e639f08 Compare February 18, 2025 09:25
@graphite-app graphite-app bot merged commit e639f08 into canary Feb 18, 2025
66 checks passed
@graphite-app graphite-app bot deleted the l-sun/chore/remove-feature-flags branch February 18, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants