Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): unable to explain image when network search is active #10228

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

akumatus
Copy link
Member

@akumatus akumatus commented Feb 17, 2025

Fix issue PD-2316.

@akumatus akumatus marked this pull request as ready for review February 17, 2025 10:57
@github-actions github-actions bot added test Related to test cases app:core labels Feb 17, 2025
@graphite-app graphite-app bot requested review from a team February 17, 2025 10:57
Copy link
Member Author

akumatus commented Feb 17, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@akumatus akumatus requested review from donteatfriedrice and a team and removed request for a team February 17, 2025 10:57
@akumatus akumatus changed the title fix(core): can not explain image when network search is active fix(core): unable to explain image when network search is active Feb 17, 2025
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 54.06%. Comparing base (eed00e0) to head (015452e).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...ocksuite/presets/ai/chat-panel/chat-panel-input.ts 0.00% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           canary   #10228   +/-   ##
=======================================
  Coverage   54.06%   54.06%           
=======================================
  Files        2327     2327           
  Lines      107091   107091           
  Branches    17746    17747    +1     
=======================================
+ Hits        57895    57896    +1     
+ Misses      47877    47876    -1     
  Partials     1319     1319           
Flag Coverage Δ
server-test 78.34% <ø> (+<0.01%) ⬆️
unittest 31.40% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akumatus akumatus force-pushed the fix/use-openai-if-has-images branch 3 times, most recently from f2011ba to 5dfb873 Compare February 17, 2025 13:59
Copy link
Member

@donteatfriedrice donteatfriedrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

graphite-app bot commented Feb 18, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the fix/use-openai-if-has-images branch from 5dfb873 to 015452e Compare February 18, 2025 02:20
@graphite-app graphite-app bot merged commit 015452e into canary Feb 18, 2025
66 checks passed
@graphite-app graphite-app bot deleted the fix/use-openai-if-has-images branch February 18, 2025 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants