fix(editor): image size and xywh when converting attachment to image #10200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
doodlewind
approved these changes
Feb 14, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #10200 +/- ##
==========================================
- Coverage 54.12% 54.11% -0.01%
==========================================
Files 2334 2335 +1
Lines 107815 107834 +19
Branches 17818 17824 +6
==========================================
+ Hits 58350 58357 +7
- Misses 48134 48147 +13
+ Partials 1331 1330 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
fundon
force-pushed
the
fundon/02_15_fix_image_size_when_converting_attachment_to_image
branch
2 times, most recently
from
cd04817 to
c1d5cd4
Compare
fundon
changed the base branch from
fundon/02_15_fix_video_style_in_edgeless
to
graphite-base/10200
fundon
force-pushed
the
graphite-base/10200
branch
from
e1117f8 to
978352c
Compare
fundon
force-pushed
the
fundon/02_15_fix_image_size_when_converting_attachment_to_image
branch
from
c1d5cd4 to
c8215bd
Compare
fundon
force-pushed
the
graphite-base/10200
branch
from
978352c to
b65cb4a
Compare
fundon
force-pushed
the
fundon/02_15_fix_image_size_when_converting_attachment_to_image
branch
from
c8215bd to
64d9e79
Compare
fundon
force-pushed
the
graphite-base/10200
branch
from
b65cb4a to
b4274ec
Compare
fundon
force-pushed
the
fundon/02_15_fix_image_size_when_converting_attachment_to_image
branch
from
64d9e79 to
d68b354
Compare
fundon
force-pushed
the
graphite-base/10200
branch
from
b4274ec to
ea94268
Compare
fundon
force-pushed
the
fundon/02_15_fix_image_size_when_converting_attachment_to_image
branch
from
d68b354 to
dfc6d57
Compare
fundon
force-pushed
the
graphite-base/10200
branch
from
ea94268 to
71aa9af
Compare
fundon
force-pushed
the
fundon/02_15_fix_image_size_when_converting_attachment_to_image
branch
2 times, most recently
from
203cac0 to
bf5f965
Compare
fundon
force-pushed
the
graphite-base/10200
branch
from
71aa9af to
180976c
Compare
fundon
force-pushed
the
fundon/02_15_fix_image_size_when_converting_attachment_to_image
branch
from
bf5f965 to
5c90dbf
Compare
fundon
force-pushed
the
graphite-base/10200
branch
from
180976c to
280a26c
Compare
fundon
changed the base branch from
graphite-base/10200
to
fundon/02_15_fix_video_style_in_edgeless
fundon
force-pushed
the
fundon/02_15_fix_image_size_when_converting_attachment_to_image
branch
from
5c90dbf to
d4a96d4
Compare
fundon
changed the base branch from
fundon/02_15_fix_video_style_in_edgeless
to
graphite-base/10200
fundon
force-pushed
the
fundon/02_15_fix_image_size_when_converting_attachment_to_image
branch
from
d4a96d4 to
555f9f5
Compare
fundon
force-pushed
the
graphite-base/10200
branch
from
280a26c to
6dc1fef
Compare
fundon
force-pushed
the
fundon/02_15_fix_image_size_when_converting_attachment_to_image
branch
from
555f9f5 to
08cd5a3
Compare
fundon
force-pushed
the
fundon/02_15_fix_image_size_when_converting_attachment_to_image
branch
from
08cd5a3 to
8bfa101
Compare
Merge activity
|
…10200) In Edgeless, the image size should be read when converting attachment to image: * fix `size` * fix `xywh`
graphite-app
bot
force-pushed
the
fundon/02_15_fix_image_size_when_converting_attachment_to_image
branch
from
3bd162d to
adc0038
Compare
graphite-app
bot
deleted the
fundon/02_15_fix_image_size_when_converting_attachment_to_image
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Edgeless, the image size should be read when converting attachment to image:
sizexywh