Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): center peek open doc should only load doc when idle #10023

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Feb 7, 2025

fix AF-2183

Copy link
Collaborator Author

pengx17 commented Feb 7, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@pengx17 pengx17 marked this pull request as ready for review February 7, 2025 09:33
@graphite-app graphite-app bot requested review from a team February 7, 2025 09:33
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 53.67%. Comparing base (b1d7128) to head (d89d4a7).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...ges/frontend/core/src/modules/doc/services/docs.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary   #10023      +/-   ##
==========================================
+ Coverage   53.66%   53.67%   +0.01%     
==========================================
  Files        2288     2288              
  Lines      104679   104683       +4     
  Branches    17421    17420       -1     
==========================================
+ Hits        56179    56192      +13     
+ Misses      47131    47123       -8     
+ Partials     1369     1368       -1     
Flag Coverage Δ
server-test 78.15% <ø> (+0.04%) ⬆️
unittest 31.71% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the xp/02-07-feat_core_center_peek_open_doc_should_only_load_doc_when_idle branch 2 times, most recently from 73846fb to 9e19158 Compare February 11, 2025 02:03
Copy link

graphite-app bot commented Feb 11, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the xp/02-07-feat_core_center_peek_open_doc_should_only_load_doc_when_idle branch from 9e19158 to d89d4a7 Compare February 11, 2025 04:56
@graphite-app graphite-app bot merged commit d89d4a7 into canary Feb 11, 2025
64 checks passed
@graphite-app graphite-app bot deleted the xp/02-07-feat_core_center_peek_open_doc_should_only_load_doc_when_idle branch February 11, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants