Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): make some tabs in sidebar persistent for all docs page #10014

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Feb 7, 2025

close AF-2164

CleanShot 2025-02-07 at 14.23.36.gif

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@CatsJuice CatsJuice marked this pull request as ready for review February 7, 2025 06:24
@graphite-app graphite-app bot requested review from a team February 7, 2025 06:24
@CatsJuice CatsJuice force-pushed the catsjuice/feat/persist-sidebar-tabs branch from a7f5751 to 4b5d3b5 Compare February 7, 2025 06:26
Copy link
Collaborator

@pengx17 pengx17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a simple test case?

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.69%. Comparing base (c78d6b8) to head (f774868).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary   #10014      +/-   ##
==========================================
- Coverage   53.69%   53.69%   -0.01%     
==========================================
  Files        2285     2285              
  Lines      104621   104621              
  Branches    17411    17409       -2     
==========================================
- Hits        56175    56172       -3     
- Misses      47080    47084       +4     
+ Partials     1366     1365       -1     
Flag Coverage Δ
server-test 78.16% <ø> (+<0.01%) ⬆️
unittest 31.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added mod:component test Related to test cases labels Feb 10, 2025
Copy link

graphite-app bot commented Feb 10, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the catsjuice/feat/persist-sidebar-tabs branch from 8ee46d2 to f774868 Compare February 10, 2025 14:58
@graphite-app graphite-app bot merged commit f774868 into canary Feb 10, 2025
64 checks passed
@graphite-app graphite-app bot deleted the catsjuice/feat/persist-sidebar-tabs branch February 10, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants