fix(server): log error on gcloud (#10235)

toeverything · Feb 18, 2025 · bae1a7f · bae1a7f
1 parent b2654ff
commit bae1a7f
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 11 deletions.
diff --git a/packages/backend/server/src/base/logger/service.ts b/packages/backend/server/src/base/logger/service.ts
@@ -18,6 +18,18 @@ export class AFFiNELogger extends ConsoleLogger {
     return ClsServiceManager.getClsService()?.getId();
   }
 
+  static formatStack(stackOrError?: Error | string | unknown) {
+    if (stackOrError instanceof Error) {
+      const err = stackOrError;
+      let stack = err.stack ?? '';
+      if (err.cause instanceof Error && err.cause.stack) {
+        stack += `\n\nCaused by:\n\n${err.cause.stack}`;
+      }
+      return stack;
+    }
+    return stackOrError;
+  }
+
   /**
    * Nestjs ConsoleLogger.error() will not print the stack trace if the error is an instance of Error
    * This method is a workaround to print the stack trace
@@ -32,15 +44,6 @@ export class AFFiNELogger extends ConsoleLogger {
     stackOrError?: Error | string | unknown,
     context?: string
   ) {
-    let stack = '';
-    if (stackOrError instanceof Error) {
-      const err = stackOrError;
-      stack = err.stack ?? '';
-      if (err.cause instanceof Error && err.cause.stack) {
-        stack += `\n\nCaused by:\n\n${err.cause.stack}`;
-      }
-      stackOrError = stack;
-    }
-    super.error(message, stackOrError, context);
+    super.error(message, AFFiNELogger.formatStack(stackOrError), context);
   }
 }
diff --git a/packages/backend/server/src/plugins/gcloud/logging/logger.ts b/packages/backend/server/src/plugins/gcloud/logging/logger.ts
@@ -8,6 +8,10 @@ export class AFFiNELogger extends WinstonLogger {
     stackOrError?: Error | string | unknown,
     context?: string
   ) {
-    RawAFFiNELogger.prototype.error.call(this, message, stackOrError, context);
+    super.error(
+      message,
+      RawAFFiNELogger.formatStack(stackOrError) as string,
+      context
+    );
   }
 }