[1837] Use backtracking graph in the token step #11602
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1837 has two graphs: a standard one and one that allows track to backtrack at junctions. The latter is needed for placing station tokens, where this type of route is allowed. The token step was not using this graph, it was using the standard one. This meant that not all possible token locations were being included, and an auto-pass was being generated for the token step if the only possible token locations involved backtracking. Fixes tobymao#11600.
crericha
reviewed
Mar 6, 2025
lib/engine/game/g_1837/step/token.rb
Outdated
| @@ -27,7 +27,7 @@ def can_place_token?(entity) | |||
| # Cheaper to do the graph first, then check affordability | |||
| current_entity == entity && | |||
| !(token = entity.next_token).nil? && | |||
| @game.graph.can_token?(entity) && | |||
| @game.token_graph.can_token?(entity) && | |||
There was a problem hiding this comment.
@game.token_graph_for_entity(entity).can_token?(entity)
There was a problem hiding this comment.
Updated (even though it does the same thing).
crericha
reviewed
Mar 6, 2025
lib/engine/game/g_1837/step/token.rb
Outdated
| @@ -40,7 +40,7 @@ def multiple_tokens?(entity) | |||
| end | |||
|
|
|||
| def can_afford_token?(token, cash) | |||
| @game.graph.tokenable_cities(token.corporation).any? do |city| | |||
| @game.token_graph.tokenable_cities(token.corporation).any? do |city| | |||
There was a problem hiding this comment.
@game.token_graph_for_entity(entity).tokenable_cities(token.corporation).any?
Change requested from code review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
1837 has two graphs: a standard one and one that allows track to backtrack at junctions. The latter is needed for placing station tokens, where this type of route is allowed.
The token step was not using this graph, it was using the standard one. This meant that not all possible token locations were being included, and an auto-pass was being generated for the token step if the only possible token locations involved backtracking.
Fixes #11600.
This shouldn't break any games. There will be games where the BH should have been able to lay a token on its first turn but wasn't allowed to, but a pass action will have been generated for those turns and that will be in the game actions.
Before clicking "Create"
masterAdd thepinsorarchive_alpha_gameslabel if this change will break existing gamesdocker compose exec rack rubocop -adocker compose exec rack rake