✨ Added the possibility to configure the PollReply #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to conform to Art-Net 4 and have the possibility to handle more than 4 universes per device. tobiasebsen#2
getAddress and getStartAdress to handle the port selection the madmapper way
|
Hello Tobias, The bind ip itself is not enough for multiple artnet 4 compliant poll replies. (cf. 7063ebf) Regards |
|
Up ? |
|
Hello there, anybody there ? |
|
@xseignard great work! Have you tried if your commits work well? Actually i don't understand why your two new methods are necessary. I introduced two new possible future changes in the issue section, moreover i think that, in order to support ArtNet v4 multi-ports devices, it would be better a new automatic artpollreply method implementation, based on bindIp concept. What do you think about? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to conform to Art-Net 4 and have the possibility to handle more than 4 universes per device. #2