Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use native xmllint for schema validation on linux #273

Merged
merged 1 commit into from
May 21, 2019

Conversation

mitakuye
Copy link
Contributor

Using version 2.5.0 we were having problems with java causing ENOMEM, libxml-xsd won't compile against node 10.15 so we tried using node-xmllint for schema validation. The server would crash unexpectedly without a stack trace. So, I have been testing with validate-with-xmllint, which uses native OS xmllint (via libxml2-utils package for debian)..instead of the node-xmllint which is an Emscripten port of xmllint. node-xmllint hasn't been updated in 3 years and libxml-xsd hasn't been updated in 3 years either. Validate-with-xmllint is typescript, and it's only 2 months old but the best part is that its a very lightweight wrapper around the system xmllint so there is very little code to maintain. The xmllint on the system is maintained by the Linux OS developers and the GNOME project which both have very active development teams.

Testing:
Tested on Debian after installing libxml2-utils and removing all other SchemaValidators.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 87.61% when pulling 97ec253 on haoleman:native-xmllint into d22ace7 on tngan:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 87.61% when pulling 97ec253 on haoleman:native-xmllint into d22ace7 on tngan:master.

@tngan tngan merged commit e2e20c1 into tngan:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants