Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue found when trying Single Log-Out service #230

Merged
merged 4 commits into from
Dec 1, 2018
Merged

Issue found when trying Single Log-Out service #230

merged 4 commits into from
Dec 1, 2018

Conversation

LynnZeng
Copy link
Contributor

@LynnZeng LynnZeng commented Nov 30, 2018 •
edited
Loading

When SingleLogoutService only have one binding method in IdP metadata, this.meta.singleLogoutService is an object instead of array, which will throw an exception this.meta.singleLogoutService.find is not a function

So my PR is to add a type check

@coveralls
Copy link

coveralls commented Nov 30, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 89.318% when pulling 96df573 on LynnZeng:master into 769478d on tngan:master.

@tngan tngan merged commit 7166012 into tngan:master Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LynnZeng @coveralls @tngan