logoutRequestRedirectURL now replaces required and custom tags #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franklinjjeng
commented
Aug 15, 2018
| IssueInstant: new Date().toISOString(), | ||
| NameIDFormat: namespace.format[initSetting.logoutNameIDFormat] || namespace.format.emailAddress, | ||
| NameID: user.logoutNameID, | ||
| SessionIndex: user.sessionIndex, |
There was a problem hiding this comment.
SessionIndex is not a required field, but it was already being added. Leaving this in here to prevent potential issues with others
There was a problem hiding this comment.
SessionIndex is not being added into the default template.
There was a problem hiding this comment.
@tngan you are correct. It's not being used, but looking at line 145 of the original code, it was added in there. I could remove this line, but I left it in to avoid unintended side affects.
There was a problem hiding this comment.
Interesting. Okay, let's keep it first. I am working on a big revamp as well.
franklinjjeng
commented
Aug 15, 2018
| @@ -214,12 +214,12 @@ test('create post login response', async t => { | |||
| }); | |||
|
|
|||
| test('create logout request with redirect binding', t => { | |||
| const { id, context } = sp.createLogoutRequest(idp, 'redirect', { email: 'user@esaml2' }); | |||
| const { id, context } = sp.createLogoutRequest(idp, 'redirect', { logoutNameID: 'user@esaml2' }); | |||
There was a problem hiding this comment.
NameID looks for user.logoutNameID
This was referenced Aug 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating logic of
customReplaceTagto accept tags created by the entity.callback function for
createLogoutRequestwould look like thiscustomReplaceTagsByValuebeing a function that returns { context, id } and can be very similar tolibsaml.replaceTagsByValuePR associated with #196