Is version 2.3.3 published on npm?

[gtothesquare]

I'm having issues with the latest npm deploy. I made sure version 2.3.3 was installed. However, the fix for parsing SessionIndex (was added in PR #137), is not working.

I tried installing it via pulling from the latest from master, building it locally (yarn build) and then installing via local file ref in the package json ("samlify": "file:../samlify") and it works.

Not familiar with how packages build with TS work but @tngan maybe you forgot to build it before releasing it ?

[tngan]

@gtothesquare It should be included. You can check out both src/entity-sp.ts and build/src/entity-sp.js inside node_modules/samlify, the pull request and its build are included.

[gtothesquare]

@tngan is missing in the build

Here is the ts source

[tngan]

@gtothesquare I have reinstalled samlify with npm, and check inside node_modules, the changes are included in the entity-sp.js line 110. Please also let me know which npm version you are using, I am using v5.3.

# my reinstallation script
$ npm install samlify@latest
$ vi node_modules/samlify/build/src/entity-sp.js

[tngan]

@gtothesquare Please send an email to passify.io@gmail.com if you still encounter same problem, we can probably schedule a call to get rid of it. :)

[gtothesquare]

@tngan i'm using yarn 1.2.1 but tried with npm 5.5.1 . (node 8.7.0) I clean cache of both npm and yarn and still get the same issue. Deleted the folder and tried from another folder with a project that just has a package.json with samlify.

I notice that the changelog is still there, which you have removed.

[tngan]

@gtothesquare The deletion of changelog is not yet pushed to npm. I know what problem in my computer as well, the node_module/samlify folder somehow symlinks with my local development folder, so what I have seen is the build version, that's why I saw the changes. I will publish a new version for it now.

[tngan]

@gtothesquare Sorry for causing inconvenience, it's bumped to v2.3.4 now.

[gtothesquare]

@tngan thanks!!!!

[tngan]

@gtothesquare Before I published to npm, I would run test first, and the test script includes the build script as well. I will try to made a pre-push hook to streamline and avoid same issue from happening again, thank you for raising the issue. 👍