Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parses SessionIndex in the login response #137

Merged
merged 1 commit into from
Oct 11, 2017

Conversation

gtothesquare
Copy link
Contributor

@gtothesquare gtothesquare commented Oct 11, 2017

@tngan Not sure if this is the way to go, but It seems that samlify needs the SessionIndex to start a logout request. However, is not parse during the loginResponse. So, this PRs adds it.

@coveralls
Copy link

coveralls commented Oct 11, 2017

Coverage Status

Coverage remained the same at 89.273% when pulling 0f67f25 on gtothesquare:session-index-parsing into 21b9035 on tngan:master.

@tngan
Copy link
Owner

tngan commented Oct 11, 2017

Apparently, the purpose of session index is used to identify which session is being logged out, so that it's worth to include it during the parsing process, thanks @gtothesquare.

@tngan tngan merged commit c71f9f6 into tngan:master Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants