Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add monochrome icon #132

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Add monochrome icon #132

merged 1 commit into from
Nov 1, 2023

Conversation

Biswa96
Copy link
Contributor

@Biswa96 Biswa96 commented Oct 30, 2023

Fixes #114

@Biswa96
Copy link
Contributor Author

Biswa96 commented Oct 30, 2023

The new monochrome icon is based on previous colored icon created by @Donnnno . I have just traced it in Inkscape and followed the steps from official documentation https://developer.android.com/develop/ui/views/launch/icon_design_adaptive

@tmo1
Copy link
Owner

tmo1 commented Oct 31, 2023

Thank you!

I tested this on an AVD (Pixel 7, Android 34), and I found that the system still displayed the regular color icon, and not the new monochrome one, until I added the <monochrome android:drawable="@drawable/ic_launcher_monochrome"/> line to app/src/main/res/mipmap-anydpi-v26/ic_launcher_round.xml in addition to app/src/main/res/mipmap-anydpi-v26/ic_launcher.xml. Please verify and fix as appropriate.

@Biswa96
Copy link
Contributor Author

Biswa96 commented Nov 1, 2023

Yeah, you are right. I missed the round icon. Though round icon is not required for this kind of normal drawing. Round icon is used "only if you require a different icon asset for circular masks—for example, if your branding relies on a circular shape."1

Footnotes

  1. https://developer.android.com/develop/ui/views/launch/icon_design_adaptive

@tmo1
Copy link
Owner

tmo1 commented Nov 1, 2023

Yeah, you are right. I missed the round icon. Though round icon is not required for this kind of normal drawing. Round icon is used "only if you require a different icon asset for circular masks—for example, if your branding relies on a circular shape."

Yes, I saw that. The round icon may not be required in our case, and I'm not sure why @Donnnno added it, but I guess that once it's there, it needs to have the monochrome tag included.

@Donnnno
Copy link
Contributor

Donnnno commented Nov 1, 2023

I have no idea anymore either!

@tmo1 tmo1 merged commit 4f1f9a1 into tmo1:master Nov 1, 2023
@tmo1
Copy link
Owner

tmo1 commented Nov 1, 2023

Thank you! Merged, and credited in CONTRIBUTING.md

@Biswa96 Biswa96 deleted the add-monochrome-icon branch November 1, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for monochromatic adaptive launcher icons
3 participants