Skip to content

Testing setup improvements #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2022
Merged

Conversation

ptrdom
Copy link
Contributor

@ptrdom ptrdom commented Jan 20, 2022

References #515.

I though about two ways of implementing this - either having multiple sbt modules for each Postgres version, or just passing the Postgres version in environmental/vm variables. Latter option seemed to be easier to maintain - when new Postgres version comes out, only thing that will need to be added to CI will be a new value into the strategy matrix.

…/14, Scala 2.11.12/2.12.13/2.13.5 and Java 8/11.
@ptrdom
Copy link
Contributor Author

ptrdom commented Jan 20, 2022

@tminglei I think you need to enable the GitHub Action workflow that I have added - https://docs.github.com/en/actions/managing-workflow-runs/disabling-and-enabling-a-workflow.

@tminglei tminglei merged commit e95bc32 into tminglei:master Jan 22, 2022
@tminglei
Copy link
Owner

Merged. Thanks! 👍

@ptrdom
Copy link
Contributor Author

ptrdom commented Jan 22, 2022

@tminglei Hmm, there seem to be issues with running the actions, this needs a closer look. We merged a bit early :) I will check it out.

tminglei added a commit that referenced this pull request Jan 23, 2022
@tminglei
Copy link
Owner

@ptrdom I resolved the issue.

@ptrdom
Copy link
Contributor Author

ptrdom commented Jan 23, 2022

@ptrdom I resolved the issue.

Hmm, I would suggest to double check how env/vm argument for Postgres version is passed - currently CI in master runs only against 11. It should look something like https://github.com/ptrdom/slick-pg/blob/d760e470fecccb9d616434ebe75c8c2529d7e46e/.github/workflows/ci.yml#L19-L28.

@tminglei
Copy link
Owner

tminglei commented Jan 24, 2022

@ptrdom oh, yes, only postgres 11 was used when ci running. It seems SLICK_PG_TEST_POSTGRES_IMAGE_TAG not to be passed.

@tminglei
Copy link
Owner

@ptrdom applied your code to 851a614. It works! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants