Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressing Adam's IESG comments #1169

Merged
merged 5 commits into from
Mar 9, 2018
Merged

Addressing Adam's IESG comments #1169

merged 5 commits into from
Mar 9, 2018

Conversation

seanturner
Copy link
Contributor

No description provided.

@seanturner
Copy link
Contributor Author

@ekr I did not:

  1. add the "Chosen ciphertext attacks against protocols based on the RSA encryption standard PKCS SNI encryption #1" reference because it's already in the [JSS15] reference that's later in the sentence.
  2. I also didn't made [AEAD-LIMITS] normative.

kaduk
kaduk approved these changes Mar 8, 2018
View reviewed changes
draft-ietf-tls-tls13.md
- Elliptic curve algorithms are now in the base spec and includes new signature
algorithms, such as ed25519 and ed448. TLS 1.3 removed point format
- Elliptic curve algorithms are now in the base spec and new signature
algorithms, such as ed25519 and ed448, are included. TLS 1.3 removed point format
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will conflict with #1166 (but don't care which version is used).

ekr
ekr requested changes Mar 9, 2018
View reviewed changes
draft-ietf-tls-tls13.md Outdated
The context string for a client signature is:
~~~
"TLS 1.3, client CertificateVerify"
~~~~
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are going to indent like this, then you should remove the quotes. I tend to think we should just tell RFC-ed to break the line in the convenient place.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do.

@ekr ekr merged commit 791e19b into master Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekr ekr ekr requested changes

@kaduk kaduk kaduk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seanturner @ekr @kaduk