Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RTL support #8

Merged
merged 2 commits into from
Jan 4, 2020
Merged

Add RTL support #8

merged 2 commits into from
Jan 4, 2020

Conversation

mhrabiee
Copy link
Contributor

Add RTL mode to support languages like: Persian, Arabic and Hebrew.
Using standard HTML's dir attribute.

@mhrabiee
Add RTL support
f9f82ff 
Add RTL mode to support languages like: Persian, Arabic and Hebrew.
Using standard HTML's `dir` attribute.
@mhrabiee mhrabiee mentioned this pull request Oct 10, 2019
Closed
tkrotoff
tkrotoff requested changes Oct 10, 2019
View reviewed changes
Copy link
Owner

@tkrotoff tkrotoff left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the PR, I didn't know anything about RTL :-)

@niftylettuce
Copy link

Merge?

@tkrotoff tkrotoff merged commit dd12c92 into tkrotoff:master Jan 4, 2020
@tkrotoff
Copy link
Owner

tkrotoff commented Jan 4, 2020

The PR was still missing the update to example/index.html. Anyway, I've merged then fixed this.
Thx

@mhrabiee mhrabiee deleted the patch-1 branch January 5, 2020 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkrotoff tkrotoff tkrotoff requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhrabiee @niftylettuce @tkrotoff