add jbang catalog #54
Conversation
| @@ -48,7 +48,7 @@ The CLI can be run with [jbang](https://www.jbang.dev/download/). | |||
| curl -Ls https://sh.jbang.dev | bash -s - app setup | |||
|
|
|||
| #Install Jlama CLI (will ask if you trust the source) | |||
| jbang app install -j 21 --name=jlama --force https://raw.githubusercontent.com/tjake/Jlama/main/jlama.java | |||
There was a problem hiding this comment.
No need to state Java 21 here as script now requires it. You can still add it if you want to try with higher Java version.
Also name is redundant as it would derive it from the file name anyway.
.github/workflows/build.yml
Outdated
|
|
||
| jobs: | ||
| build: | ||
| uses: jbanghub/.github/.github/workflows/shared-build.yml@main |
There was a problem hiding this comment.
This workflow file just ensures that the JBang catalog scripts can resolve all its deps and compile.
jlama.java
Outdated
| @@ -1,8 +1,9 @@ | |||
| ///usr/bin/env jbang "$0" "$@" ; exit $? | |||
| //COMPILE_OPTIONS -source 20 | |||
| //JAVA 21+ | |||
| //PREVIEW | |||
There was a problem hiding this comment.
This automatically handles --enable-preview and source targets are aligned.
You can also do it all manually and explicitly but lets things that can break this way.
There was a problem hiding this comment.
It's actually 20+ does that also handle --enable-preview?
There was a problem hiding this comment.
yes, i put 21 as thats what you put in the readme. //preview will take the java version and apply for --source/--release so its all aligned and you don't have to change them all just because you try it out with java 23 for example.
want me to change it to //JAVA 20+ ?
There was a problem hiding this comment.
I kind of like your suggestion of the separate repo so I made one here
One question I had, can I have the installer include this compiler directives file I couldn't see how to do that without placing it manually?
Thanks for your help!
jlama.java
Outdated
| @@ -1,8 +1,9 @@ | |||
| ///usr/bin/env jbang "$0" "$@" ; exit $? | |||
| //COMPILE_OPTIONS -source 20 | |||
| //JAVA 21+ | |||
| //PREVIEW | |||
There was a problem hiding this comment.
It's actually 20+ does that also handle --enable-preview?
cool - I'll "port" this pr over there.
TIL - java compiler directives files! I think there is a way to support it nicely using jbangs "remote file arguments" feature https://www.jbang.dev/documentation/guide/latest/running.html#remote-file-arguments allows you to do |
|
fyi, the remote file argument trick does not work at this time. I opened jbangdev/jbang#1838 to see if can make it work. |
|
Closing this since its in jbang-catalog repo. Thank you! |
just a proposal to add jbang-catalog.json so you can run this asjbang jlama@tjake/jlama+ automatic dependency updates and verification of the jbang catalog content.if this was instead put in tjake/jbang-catalog repo it would be even shorter to run and not "overlap" with jlama itself.updated readme and remove jlama.java as redundant now with tjake/jbang-catalog#1