Support grpc-web-text format with envoy. #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Envoy replies with application/grpc-web+proto, regardless of the specified request content type. Envoy only replies with application/grpc-web-text when the accept request header was set explicitly. This fix sets `accept: application/grpc-web-text` when requesting in text format. The fix also looks at the response content type to determine which format to parse.
timostamm
added a commit
that referenced
this pull request
Dec 20, 2020
timostamm
added a commit
that referenced
this pull request
Dec 22, 2020
andy-clymer
pushed a commit
to andy-clymer/protobuf-ts
that referenced
this pull request
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Envoy replies with application/grpc-web+proto, regardless of the specified request content type.
Envoy only replies with application/grpc-web-text when the accept request header was set explicitly.
This fix sets
accept: application/grpc-web-textwhen requesting in text format.The fix also looks at the response content type to determine which format to parse.