fix: @protobuf-ts/grpc-transport memory leak #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dddenis
force-pushed
the
fix/grpc-transport-memory-leak
branch
from
4ec8113 to
70f4fe6
Compare
|
Thank you @dddenis. I am completely swamped right now with work and it will take me a few days to come back to this. |
|
@timostamm sure, ping me when I should rebase on top of latest master |
|
Excellent! If you could rebase (to accept masters new lock files) I'll merge and publish straight away. |
dddenis
force-pushed
the
fix/grpc-transport-memory-leak
branch
from
70f4fe6 to
6ec85cf
Compare
|
done |
|
Thank you 🙏 Published in v2.0.0-alpha.27 in the "next" channel. |
|
thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CallOptionsfromGrpcOptions@grpc/grpc-jsClient once inGrpcTransportconstructorclosemethod, which closes@grpc/grpc-jsClientfixes #107