Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic server support #56

Closed
16 tasks done
timostamm opened this issue Dec 21, 2020 · 4 comments
Closed
16 tasks done

Generic server support #56

timostamm opened this issue Dec 21, 2020 · 4 comments
Labels
enhancement New feature or request
Milestone
2.0

Comments

@timostamm
Copy link
Owner

timostamm commented Dec 21, 2020 •
edited
Loading

For clients, we generate a generic interface / implementation that is agnostic to the protocol.
The actual protocol implementation is delegated to a "transport".

A similar concept can be applied to servers. We generate a generic interface for a server, and provide the protocol in "backend" packages.

Proof of concept:

TODO

  • come up with sensible method signatures
  • adapter for unary
  • adapter for server streaming
  • adapter for client streaming
  • adapter for bidi streaming
  • check cancellation support
  • test deadlines
  • test error handling
  • fix UnhandledPromiseRejectionWarning when cancelling client call, see client-cancel-test.ts
  • generate generic server interfaces (proto-file-name.server.ts)
  • add plugin parameter "server_generic"
  • add server style GENERIC
  • example package
  • documentation (example-chat-system, MANUAL.md)
@timostamm timostamm added the enhancement New feature or request label Dec 21, 2020
timostamm added a commit that referenced this issue Dec 22, 2020
@timostamm
#56 move ServerCallContext to runtime-rpc
2182c06
timostamm added a commit that referenced this issue Dec 22, 2020
@timostamm
#56 create grpc-backend package
e6cd5d4
timostamm added a commit that referenced this issue Dec 22, 2020
@timostamm
#56 create example package for generic server
30a7a43
timostamm added a commit that referenced this issue Dec 22, 2020
@timostamm
#56 generate generic server interfaces
51a57ce
@timostamm
Copy link
Owner Author

Released in v2.0.0-alpha.9

timostamm added a commit that referenced this issue Dec 22, 2020
@timostamm
#56 add cancellation support
9aabbd5
timostamm added a commit that referenced this issue Dec 22, 2020
@timostamm
#56 add chat example
6968542
timostamm added a commit that referenced this issue Dec 22, 2020
@timostamm
#56 add test code for promise rejections
04a93b1
timostamm added a commit that referenced this issue Dec 22, 2020
@timostamm
#56 add test code for promise rejections
bea16fc
@timostamm
Copy link
Owner Author

Updated in v2.0.0-alpha.10

timostamm added a commit that referenced this issue Dec 22, 2020
@timostamm
#56 make chat client interactive
6b45bf6
timostamm added a commit that referenced this issue Dec 22, 2020
@timostamm
#56 make chat client interactive
1840aec
timostamm added a commit that referenced this issue Dec 23, 2020
@timostamm
#56 refactor chat system files
aa4540e
timostamm added a commit that referenced this issue Dec 31, 2020
@timostamm
#56 notes for cancellation support
54d5e99
@timostamm
Copy link
Owner Author

Deadline cancellation on server through grpc-backend do not work correctly. Getting the same error about incomplete chunked encoding as in smnbbrv/ngx-grpc#41

@timostamm timostamm mentioned this issue Jan 27, 2021
Closed
timostamm added a commit that referenced this issue Jan 30, 2021
@timostamm
#56 add notes
15b554b
timostamm added a commit that referenced this issue Feb 13, 2021
@timostamm
#56 add log statement
928ed08
timostamm added a commit that referenced this issue Feb 13, 2021
@timostamm
#56 cleaned up and documented example code
c9d5cd2
@timostamm timostamm mentioned this issue Apr 10, 2021
Closed
@timostamm timostamm added this to the 2.0 milestone Apr 10, 2021
@timostamm timostamm mentioned this issue Jun 17, 2021
Closed
@timostamm
Copy link
Owner Author

Running with generic servers as experimental.

Fixed the readme of @protobuf-ts/grpc-backend, added the plugin option in the manual, added a very short section in the manual, making sure to note experimental status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@timostamm