-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updated to angular 18 #125
chore: updated to angular 18 #125
Conversation
Could you please revert all changes related to yarn.lock / package.lock and yarn itself. This project uses yarn as package manager. You don't need to install packages in |
I removed the lock files in projects/angular-cc-library, however i had to change yarn version to 1.22.22 due to a bug regarding the require function not working in tests files |
Interesting, don't have an idea how yarn could affect tests. Anyway updating a version is a good thing. PS The package manager configuration now could be switched from yarn's approach to node's corepack. It could be done in a separate PR. |
Just for future reference, i followed the instruction in this issue to resolve the problem i faced with yarn: |
Ok thanks guys for jumping on this! I tried to upgrade Yarn also but wasnt exactly sure what I was doing and it didnt seem to work. |
@cwithhart it looks like the npm publish command on the automatic github actions failed, i think that @thekip needs to take a at it and after that it should be online on NPM https://github.com/thekip/angular-cc-library/actions/runs/10703285053 |
Yea i just noticed the release failed. Thanks for the update! |
No description provided.