Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated to angular 18 #125

Conversation

s-torrisi
Copy link
Contributor

No description provided.

@s-torrisi s-torrisi mentioned this pull request Sep 4, 2024
@timofei-iatsenko
Copy link
Owner

Could you please revert all changes related to yarn.lock / package.lock and yarn itself. This project uses yarn as package manager. You don't need to install packages in projects/angular-cc-library folder. The package.json file there used only for publishing.

@s-torrisi
Copy link
Contributor Author

s-torrisi commented Sep 4, 2024

Could you please revert all changes related to yarn.lock / package.lock and yarn itself. This project uses yarn as package manager. You don't need to install packages in projects/angular-cc-library folder. The package.json file there used only for publishing.

I removed the lock files in projects/angular-cc-library, however i had to change yarn version to 1.22.22 due to a bug regarding the require function not working in tests files

@timofei-iatsenko
Copy link
Owner

Interesting, don't have an idea how yarn could affect tests. Anyway updating a version is a good thing.

PS

The package manager configuration now could be switched from yarn's approach to node's corepack. It could be done in a separate PR.

@timofei-iatsenko timofei-iatsenko merged commit 9afcd03 into timofei-iatsenko:master Sep 4, 2024
@s-torrisi
Copy link
Contributor Author

Just for future reference, i followed the instruction in this issue to resolve the problem i faced with yarn:
yargs/cliui#159

@s-torrisi s-torrisi deleted the updating-packages-and-tests-fix branch September 4, 2024 14:06
@cwithhart
Copy link
Contributor

Ok thanks guys for jumping on this! I tried to upgrade Yarn also but wasnt exactly sure what I was doing and it didnt seem to work.
@s-torrisi - Is there anything you need from me to move forward? Looks like you merged it back into the main branch and all is good?
Also, will it auto kick off the a new NPM? Or is there another step needed. Thanks again everyone!

@s-torrisi
Copy link
Contributor Author

@cwithhart it looks like the npm publish command on the automatic github actions failed, i think that @thekip needs to take a at it and after that it should be online on NPM

https://github.com/thekip/angular-cc-library/actions/runs/10703285053

@cwithhart
Copy link
Contributor

Yea i just noticed the release failed. Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants