Update to pgrx 0.9.7 #762
Merged
Update to pgrx 0.9.7 #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syvb
force-pushed
the
sv/pgrx-0.9.1
branch
2 times, most recently
from
eb93356 to
ae22b99
Compare
thatzopoulos
reviewed
Jul 5, 2023
tools/update-tester/src/installer.rs
Outdated
Comment on lines
96
to
107
| fn get_pgrx_version(cargo_toml_contents: &str) -> Version { | ||
| let cargo = cargo_toml_contents | ||
| .parse::<Document>() | ||
| .expect("invalid Cargo.toml"); | ||
|
|
||
| cargo["dependencies"]["pgx"] | ||
| cargo["dependencies"]["pgrx"] | ||
| .as_str() | ||
| .expect("expected pgx to only have a version") | ||
| .expect("expected pgrx to only have a version") | ||
| .trim_start_matches(['=', '^', '~'].as_slice()) | ||
| .parse() | ||
| .expect("cannot parse pgx version") | ||
| .expect("cannot parse pgrx version") | ||
| } |
There was a problem hiding this comment.
I think we might run into some issues with the update-tester here. After checking out a git tag, get_pgrx_version() will read the new Cargo.toml from the filesystem, which will still be listed as 'pgx' for all but this newest version which I think will cause a panic. I don't think any of the other update-tester changes should cause any problems.
WireBaron
approved these changes
Jul 6, 2023
thatzopoulos
approved these changes
Jul 6, 2023
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.