Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize nmost functions #751

Merged
merged 3 commits into from
Apr 5, 2023
Merged

Stabilize nmost functions #751

merged 3 commits into from
Apr 5, 2023

Conversation

syvb
Copy link
Member

@syvb syvb commented Apr 3, 2023 •
edited
Loading

Note that I didn't add arrow accessors for into_values for min_n_by/max_n_by since those functions take dummy NULLs.

@syvb syvb marked this pull request as ready for review April 3, 2023 15:58
WireBaron
WireBaron approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@WireBaron WireBaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The arrow operators definitely don't play nicely with AnyElement returning functions, so no worries there.

@thatzopoulos thatzopoulos self-requested a review April 4, 2023 18:18
@syvb syvb force-pushed the sv/stabilize-min-max branch from 546e8a1 to 531b2b3 Compare April 5, 2023 15:54
@syvb syvb force-pushed the sv/stabilize-min-max branch from 531b2b3 to 29c3af6 Compare April 5, 2023 16:00
@syvb
Copy link
Member Author

syvb commented Apr 5, 2023

Merging this now so we can get #752 in without more merge conflicts.

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 5, 2023

Build succeeded:

@bors bors bot merged commit 70e8f5d into main Apr 5, 2023
@bors bors bot deleted the sv/stabilize-min-max branch April 5, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatzopoulos thatzopoulos thatzopoulos approved these changes

@WireBaron WireBaron WireBaron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@syvb @thatzopoulos @WireBaron