Make tests pass in Canadian locales #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Postgres date parsing is locale-dependent, so make dates parsed in tests use a format that is parsed the same in (hopefully) all locales. It would be better to set the locale of the database, but SETting the LC_DATE parameter doesn't seem to have an impact. Ideally pgx should set the database locale when creating a test database.
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently various date-related tests fail on my machine that's in the Canadian English (en_CA) locale. Postgres date parsing is locale-dependent, so this PR makes the dates parsed in tests use a format that is parsed the same in (hopefully) all locales.
It would be better to set the locale of the database to
en_USand write all dates US-style, but SETting the locale parameter doesn't seem to have an impact on date parsing for me. Ideally pgx should set the database locale when creating a test database to a consistent value (since some locale-related values can't be changed after database creation (not sure if date parsing is one of them)).