This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 170
Implement Jaeger gRPC remote storage writer interface #1543
Merged
arajkumar
merged 3 commits into
timescale:master
from
arajkumar:jaeger-grpc-remote-writer
Aug 8, 2022
Merged
Implement Jaeger gRPC remote storage writer interface #1543
arajkumar
merged 3 commits into
timescale:master
from
arajkumar:jaeger-grpc-remote-writer
Aug 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arajkumar
commented
Aug 2, 2022
@@ -104,7 +104,9 @@ func GenerateRouter(apiConf *Config, promqlConf *query.Config, client *pgclient. | |||
reloadHandler := timeHandler(metrics.HTTPRequestDuration, "/-/reload", Reload(reload, apiConf.AdminAPIEnabled)) | |||
router.Path("/-/reload").Methods(http.MethodPost).HandlerFunc(reloadHandler) | |||
|
|||
jaeger.ExtendQueryAPIs(router, client.ReadOnlyConnection(), query) | |||
if store != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is added to skip creation of Jaeger store when doing promql_endpoint_integration_test.go
antekresic
approved these changes
Aug 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Harkishen-Singh
suggested changes
Aug 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. My only concern is keeping translation part out of Ingestor.
This commit implements Jaeger gRPC storage writer by using otel translator package to transforms Jager `model.Span` to Otel `ptrace.Traces`. Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
Since we implemented writer interface for Jaeger gRPC remote storage, it is no longer only queryable, it is also writable. Hence the same "store". Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
Signed-off-by: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
563aeb2
to
443af74
Compare
niksajakovljevic
approved these changes
Aug 4, 2022
Harkishen-Singh
approved these changes
Aug 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sub tasks
Implements #1535.
Testing
Note: This testing strategy establishes a cyclic dependency, where the promscale exports it's internal tracing data to Jaeger collector and which would again pushes back to gRPC stroage implementation which is again promscale.
Description
This commit implements Jaeger gRPC storage writer by using otel translator package to transforms Jager
model.Span
to Otelptrace.Traces
.Signed-off-by: Arunprasad Rajkumar ar.arunprasad@gmail.com
Note: If your PR involves benchmarks, you can run the
Benchmarks
workflow by addingaction:benchmarks
label. The PR must be opened from Promscale branch so that Github actions can leave a comment comparing results againstmaster
.Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: