This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
Add HEAD and OPTIONS on healthz #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Load balancers prefer to make HEAD or OPTIONS requests for health checks as they are cheaper.
niksajakovljevic
requested review from
antekresic and
Harkishen-Singh
as code owners
Harkishen-Singh
approved these changes
May 26, 2022
sumerman
approved these changes
May 26, 2022
|
We can close related PR #1371 |
2 tasks
|
Wasn't the agreement to add OPTIONS to all endpoints? |
|
@paulfantom By looking into user issues I wasn't fully convinced if that was really needed. There are some other reasons as well, however let's discuss this more offline. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load balancers prefer to make HEAD or OPTIONS requests for health checks
as they are cheaper.
Related #710
Also some community users encountered this problem https://timescaledb.slack.com/archives/C011FC0PPC5/p1653384295441989?thread_ts=1652775715.500199&cid=C011FC0PPC5