This repository has been archived by the owner on Apr 2, 2024. It is now read-only.
deploy/helm-chart: add readinessProbe #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfantom
requested review from
cevian,
VineethReddy02,
JamesGuthrie and
a team
as code owners
JamesGuthrie
approved these changes
Mar 22, 2022
|
Seems like we need to rethink our testing strategy as the current helm chart is not installing the database and for this reason, promscale-connector cannot enter |
|
@paulfantom should I review this? It's in draft stage? |
|
No. This needs some more work and will be a good first issue for a new hire ;) |
Signed-off-by: Paweł Krupa (paulfantom) <pawel@krupa.net.pl>
onprem
force-pushed
the
helm-readiness-probe
branch
from
34bfccb to
63bbaf8
Compare
|
|
onprem
force-pushed
the
helm-readiness-probe
branch
from
63bbaf8 to
75bdd98
Compare
Signed-off-by: Prem Saraswat <prmsrswt@gmail.com>
onprem
force-pushed
the
helm-readiness-probe
branch
from
75bdd98 to
f1bfbd3
Compare
paulfantom
commented
May 30, 2022
|
You need to run |
Signed-off-by: Prem Saraswat <prmsrswt@gmail.com>
JamesGuthrie
approved these changes
May 31, 2022
niksajakovljevic
approved these changes
May 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Adding readiness probe to use
/healthzendpoint as a source of information for kubernetes traffic steering (by default kubernetes won't allow traffic flow to pod that is unhealthy).Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: