Implement ingested_spans_count in telemetry data. #1155
Conversation
Harkishen-Singh
requested review from
antekresic,
niksajakovljevic,
jgpruitt and
a team
as code owners
Harkishen-Singh
force-pushed
the
add_spans_count_in_telemetry
branch
from
5fe28b7 to
57f5d6f
Compare
Harkishen-Singh
force-pushed
the
add_spans_count_in_telemetry
branch
from
57f5d6f to
d036197
Compare
|
@paulfantom we should have a separate PR (after the release) that updates all telemetry metrics. This is why I didn't do in this PR. |
There was a problem hiding this comment.
@Harkishen-Singh ack. I was confused and though this metric would be also exposed on prometheus /metrics endpoint, which is not the case.
LGTM on green
pkg/pgclient/client.go
Outdated
| ) | ||
| telemetryEngine, err = telemetry.NewEngine(dbConn, PromscaleID, queryable) |
There was a problem hiding this comment.
I'd recommend keeping telemetry engine creation outside of Client (that reads and writes). Imho those are different concerns. It would also make it easier to test Client as we can just inject telemetry engine...
There was a problem hiding this comment.
But telemetry engine needs queryable and the client needs telemetry (for passing down to IngestTraces). So if I keep it outside, like in runner.go, it will be a egg-chicken problem.
There was a problem hiding this comment.
For now, let's leave this since it's blocking the release. I have created an issue #1156 which I will solve after the release is done.
Harkishen-Singh
force-pushed
the
add_spans_count_in_telemetry
branch
3 times, most recently
from
fa9f5e7 to
37eea31
Compare
Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>
Harkishen-Singh
force-pushed
the
add_spans_count_in_telemetry
branch
from
37eea31 to
c0b130b
Compare
Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com> This commit fixes the wrongly added 2-alter_promscale_instance_information_column.sql to 0.8.0 when the next release scheduled was 0.10, meaning the changes to schema wont be applied. This was a bug. This commit shifts the alter column file to where it should be, i.e., 0.10.0/1-alter_promscale_instance_information_column.sql which means, the existing users when update to 0.10 will have the alter column.
Harkishen-Singh
force-pushed
the
add_spans_count_in_telemetry
branch
from
c0b130b to
d3484a0
Compare
Signed-off-by: Harkishen-Singh harkishensingh@hotmail.com
Description
This PR adds ingested spans count to telemetry data collection. It does some refactoring to client as the trace ingestor needs to access telemetryEngine, which in turn also simplifies the NewClient()
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: