This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
Update README.md #540
Merged
Update README.md #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onprem
approved these changes
Jan 3, 2023
|
You'd need to bump the chart version though, for how our CI works. |
|
@onprem do I need to bump the chart version just for this change? |
|
@alejandrodnm Yes, we have CD setup to release a new version of chart with every PR, if there any changes in it's files. Since the README file is under the chart directory, we need to bump the version. Here we can just do a patch release. |
Signed-off-by: alejandrodnm <alejandrodnm@gmail.com>
alejandrodnm
force-pushed
the
alejandrodnm-patch-1
branch
from
4671cf0 to
ba1459d
Compare
|
@onprem the errors are related to a fix for the alerts that was made in this PR timescale/promscale#1794 Is there something else I need to do? |
|
I'll leave this open until the alerts are fixed on another PR |
|
I have created #541 for the alerts. And these checks are unrelated and not required for this PR so I am going ahead and merging. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: alejandrodnm alejandrodnm@gmail.com
What this PR does / why we need it
Which issue this PR fixes
Special notes for your reviewer
Checklist