Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a transition initiated with replaceWith, its retry is also a replace. #211

Merged
merged 1 commit into from
Apr 25, 2017

Conversation

cibernox
Copy link
Contributor

@cibernox cibernox commented Apr 25, 2017

Prior to this change retrying the transition would convert the replaceWith in
a regular transitionTo.

Example code (assuming this is an Ember route):

let transition = this.replaceWith('new.route');
transition.abort();
session.set('attemptedTransition', transition);
session.authenticate('authenticator:devise').authenticate(username, password); // Successful authentication will call `session.get('attemptedTransition').retry()`

…place.

Prior to this change retrying the transition would convert the `replaceWith` in
a regular `transitionTo`.
@rwjblue rwjblue merged commit 511a0ed into tildeio:master Apr 25, 2017
@rwjblue
Copy link
Collaborator

rwjblue commented Apr 25, 2017

Thanks @cibernox!

@cibernox cibernox deleted the allow-replace-with-retry branch April 25, 2017 17:57
@cibernox cibernox changed the title If a transition initiated with replaceWith, it's retry is also a replace. If a transition initiated with replaceWith, its retry is also a replace. Apr 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants