-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: unify frequency check time to make test stable #8556
Conversation
Signed-off-by: husharp <ihusharp@gmail.com>
aba2cd2
to
cdbe223
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8556 +/- ##
==========================================
- Coverage 77.68% 77.58% -0.11%
==========================================
Files 474 474
Lines 61877 61873 -4
==========================================
- Hits 48069 48002 -67
- Misses 10280 10336 +56
- Partials 3528 3535 +7
Flags with carried forward coverage won't be shown. Click here to find out more. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: Close #8555
What is changed and how does it work?
Unify changeFrequencyTimes and skipCampaignLeaderCheck
We have 2 failpoints, both designed to address
frequently change(There are many resign leader in this test and slow disk can make frequently happened in high probability
, we can unify them.for #8555
We can find PD2 campaign times by log:
SetupSuite make PD2 as leader ----- 1
TestRetryOnLeaderChange
Pd2->PD1
Pd1->PD2 -------- 2
Pd2->PD1 --------- during this resign etcd had stuck which make PD2 still can start campaign leader
PD1 -> PD2 ------- 4 And then meet frequently error
Check List
Tests
Release note