-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement na.rm
handling for sum()
, min()
, max()
, any()
and all()
, with fallback for window functions
#566
Conversation
This is how benchmark results would change (along with a 95% confidence interval in relative change) if cb4cd4f is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
sum(na.rm = TRUE)
, min(na.rm = TRUE)
and max(na.rm = TRUE)
sum(na.rm = FALSE)
, min(na.rm = FALSE)
and max(na.rm = FALSE)
sum(na.rm = FALSE)
, min(na.rm = FALSE)
and max(na.rm = FALSE)
sum(na.rm = FALSE)
, min(na.rm = FALSE)
and max(na.rm = FALSE)
, with fallback for window functions
sum(na.rm = FALSE)
, min(na.rm = FALSE)
and max(na.rm = FALSE)
, with fallback for window functionsna.rm
handling for sum()
, min()
, max()
, any()
and all()
, with fallback for window functions
Await benchmark results. |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if aa4f841 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
Review benchmarks after merging. |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 57ed3c8 is merged into main:
Further explanation regarding interpretation and methodology can be found in the documentation. |
@hannes: This is the first time when benchmarks are getting slower. This PR turns |
Closes #205.