Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: collect() returns a tibble #447

Merged
merged 1 commit into from
Jan 11, 2025
Merged

feat: collect() returns a tibble #447

merged 1 commit into from
Jan 11, 2025

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Jan 11, 2025

Closes #438.

@krlmlr krlmlr enabled auto-merge (squash) January 11, 2025 01:06
@krlmlr krlmlr merged commit 2c15b74 into main Jan 11, 2025
6 checks passed
@krlmlr krlmlr deleted the f-438-collect-tibble branch January 11, 2025 01:15
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if bd8b45b is merged into main:

  • ✔️001_tpch_01: 24.5ms -> 24.9ms [-3.08%, +6.09%]
  • ✔️001_tpch_02: 72.8ms -> 74.1ms [-1.09%, +4.48%]
  • ✔️001_tpch_03: 41.3ms -> 41.3ms [-2.11%, +2.15%]
  • ✔️001_tpch_04: 23.7ms -> 23.3ms [-4.82%, +1.3%]
  • ✔️001_tpch_05: 61.8ms -> 61.3ms [-3.5%, +2.06%]
  • 🚀001_tpch_06: 20.9ms -> 15.1ms [-31.23%, -24.61%]
  • ✔️001_tpch_07: 79.2ms -> 79.8ms [-1.43%, +2.97%]
  • ✔️001_tpch_08: 107ms -> 110ms [-0.3%, +4.63%]
  • ✔️001_tpch_09: 79.8ms -> 80.3ms [-2.41%, +3.79%]
  • ✔️001_tpch_10: 53.9ms -> 53.5ms [-3.85%, +2.52%]
  • ✔️001_tpch_11: 33.7ms -> 34.5ms [-1.09%, +5.82%]
  • ✔️001_tpch_12: 28.1ms -> 28.6ms [-0.93%, +5.08%]
  • ✔️001_tpch_13: 27.6ms -> 28.4ms [-1.68%, +7.4%]
  • ✔️001_tpch_14: 21.2ms -> 21.5ms [-2.14%, +4.7%]
  • ✔️001_tpch_15: 32.7ms -> 33ms [-1.6%, +2.88%]
  • ✔️001_tpch_16: 42ms -> 42.8ms [-1.08%, +5.24%]
  • ✔️001_tpch_17: 27.9ms -> 28.3ms [-3.09%, +5.97%]
  • ✔️001_tpch_18: 24ms -> 24.1ms [-2.97%, +4.29%]
  • ✔️001_tpch_19: 72.1ms -> 71.7ms [-2.48%, +1.41%]
  • ✔️001_tpch_20: 55.3ms -> 56.4ms [-1.12%, +4.93%]
  • ✔️001_tpch_21: 85.3ms -> 83.6ms [-4.45%, +0.52%]
  • ✔️001_tpch_22: 73.5ms -> 73ms [-3.13%, +1.93%]
  • ✔️010_tpch_01: 85ms -> 83ms [-5.97%, +1.35%]
  • ✔️010_tpch_02: 73.5ms -> 72.7ms [-4.41%, +2.1%]
  • ✔️010_tpch_03: 60.7ms -> 61.4ms [-1.15%, +3.36%]
  • ✔️010_tpch_04: 45.2ms -> 45.5ms [-5.44%, +7.05%]
  • ✔️010_tpch_05: 93.4ms -> 94.7ms [-2.83%, +5.77%]
  • ✔️010_tpch_06: 34.6ms -> 33.7ms [-11.77%, +6.41%]
  • ✔️010_tpch_07: 109ms -> 111ms [-1.34%, +4.13%]
  • ✔️010_tpch_08: 132ms -> 133ms [-2.16%, +4.13%]
  • ✔️010_tpch_09: 123ms -> 123ms [-4.05%, +4.81%]
  • ✔️010_tpch_10: 77.8ms -> 79.3ms [-2.39%, +6.04%]
  • ✔️010_tpch_11: 39.4ms -> 41.4ms [-0.32%, +10.25%]
  • ✔️010_tpch_12: 59.6ms -> 60.2ms [-3.63%, +5.71%]
  • ✔️010_tpch_13: 54ms -> 54.8ms [-1.57%, +4.55%]
  • ✔️010_tpch_14: 39.7ms -> 40.1ms [-3.69%, +5.59%]
  • ✔️010_tpch_15: 56.3ms -> 56.2ms [-4.71%, +4.38%]
  • ✔️010_tpch_16: 46.8ms -> 46.4ms [-5.43%, +3.6%]
  • ✔️010_tpch_17: 56.8ms -> 55.3ms [-6.62%, +1%]
  • ✔️010_tpch_18: 56.2ms -> 57.2ms [-7.9%, +11.61%]
  • ✔️010_tpch_19: 118ms -> 117ms [-1.6%, +0.67%]
  • ✔️010_tpch_20: 67.7ms -> 67.8ms [-2.9%, +3.27%]
  • ✔️010_tpch_21: 243ms -> 247ms [-1.03%, +4.25%]
  • ✔️010_tpch_22: 80.9ms -> 80ms [-4.83%, +2.62%]
  • ✔️100_tpch_01: 332ms -> 301ms [-19.1%, +0.66%]
  • ✔️100_tpch_02: 144ms -> 129ms [-23.31%, +2.55%]
  • ✔️100_tpch_03: 182ms -> 184ms [-1.69%, +3.75%]
  • ✔️100_tpch_04: 152ms -> 152ms [-10.33%, +10.62%]
  • ✔️100_tpch_05: 263ms -> 269ms [-1.76%, +6.07%]
  • ✔️100_tpch_06: 102ms -> 102ms [-1.86%, +1.74%]
  • ✔️100_tpch_07: 252ms -> 252ms [-10.01%, +10.18%]
  • 🚀100_tpch_08: 289ms -> 272ms [-8.79%, -2.54%]
  • ✔️100_tpch_09: 336ms -> 355ms [-11.76%, +22.72%]
  • ✔️100_tpch_10: 220ms -> 226ms [-1.54%, +6.28%]
  • ✔️100_tpch_11: 87.1ms -> 90.1ms [-14.58%, +21.47%]
  • ✔️100_tpch_12: 206ms -> 186ms [-22.68%, +3.95%]
  • ✔️100_tpch_13: 354ms -> 348ms [-13.91%, +10.76%]
  • ✔️100_tpch_14: 122ms -> 124ms [-15.67%, +20.12%]
  • 🚀100_tpch_15: 230ms -> 206ms [-20.45%, -0.05%]
  • ✔️100_tpch_16: 132ms -> 132ms [-4%, +3.52%]
  • ✔️100_tpch_17: 183ms -> 179ms [-12.68%, +8.46%]
  • ✔️100_tpch_18: 201ms -> 194ms [-8.01%, +1.04%]
  • ✔️100_tpch_19: 292ms -> 288ms [-4.68%, +1.32%]
  • ✔️100_tpch_20: 178ms -> 183ms [-2.09%, +7.99%]
  • ✔️100_tpch_21: 1.37s -> 1.34s [-8.4%, +4.53%]
  • ✔️100_tpch_22: 179ms -> 177ms [-14.69%, +11.62%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should collect() return a tibble?
1 participant