Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: New fallback_config() to create a configuration file for the settings that do not affect behavior #426

Merged
merged 2 commits into from
Dec 29, 2024
Merged

feat: New fallback_config() to create a configuration file for the settings that do not affect behavior #426

merged 2 commits into from
Dec 29, 2024

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Dec 28, 2024 •
edited
Loading

Closes #216.

@krlmlr krlmlr changed the title f 216 fallback config feat: New fallback_config() to create a configuration file Dec 28, 2024
@krlmlr krlmlr enabled auto-merge (squash) December 28, 2024 21:37
@krlmlr krlmlr changed the title feat: New fallback_config() to create a configuration file feat: New fallback_config() to create a configuration file for the settings that do not affect behavior Dec 28, 2024
@krlmlr krlmlr force-pushed the f-216-fallback-config branch from d20a415 to b261778 Compare December 28, 2024 21:39
@krlmlr krlmlr requested a review from hadley December 28, 2024 21:40
@krlmlr krlmlr mentioned this pull request Dec 28, 2024
Closed
@krlmlr krlmlr force-pushed the f-216-fallback-config branch from b261778 to 1d047ac Compare December 28, 2024 21:45
@github-actions GitHub Actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 1d047ac is merged into main:

  • ✔️001_tpch_01: 24.5ms -> 25.1ms [-1.49%, +6.78%]
  • ✔️001_tpch_02: 73.9ms -> 72.1ms [-6.31%, +1.56%]
  • ✔️001_tpch_03: 41.3ms -> 41.1ms [-2.75%, +2.15%]
  • ✔️001_tpch_04: 22.9ms -> 23ms [-1.3%, +2.07%]
  • ✔️001_tpch_05: 59ms -> 59.2ms [-1.13%, +1.81%]
  • ✔️001_tpch_06: 14.6ms -> 14.9ms [-1.49%, +5.68%]
  • ✔️001_tpch_07: 76.6ms -> 77ms [-0.98%, +2.02%]
  • ✔️001_tpch_08: 102ms -> 102ms [-2.29%, +1.43%]
  • ✔️001_tpch_09: 76.4ms -> 76.4ms [-2.11%, +2.07%]
  • ✔️001_tpch_10: 50ms -> 50.4ms [-1.29%, +2.72%]
  • ✔️001_tpch_11: 32.9ms -> 33.2ms [-0.63%, +2.46%]
  • ✔️001_tpch_12: 28.2ms -> 28ms [-3.53%, +2.06%]
  • ✔️001_tpch_13: 26.5ms -> 26.8ms [-2.06%, +4.68%]
  • ✔️001_tpch_14: 21.2ms -> 21ms [-3.49%, +1.96%]
  • ✔️001_tpch_15: 32.4ms -> 32.5ms [-1.08%, +2.11%]
  • ✔️001_tpch_16: 41.4ms -> 41.5ms [-1.44%, +1.64%]
  • ✔️001_tpch_17: 26.4ms -> 26.5ms [-1.14%, +1.96%]
  • ✔️001_tpch_18: 23.5ms -> 23ms [-4.77%, +0.51%]
  • ✔️001_tpch_19: 69.4ms -> 70.1ms [-0.66%, +2.76%]
  • ✔️001_tpch_20: 52.5ms -> 52.7ms [-1.7%, +2.77%]
  • ✔️001_tpch_21: 82.4ms -> 82.4ms [-1.74%, +1.87%]
  • ✔️001_tpch_22: 71.5ms -> 71.2ms [-3.32%, +2.58%]
  • ✔️010_tpch_01: 83.6ms -> 81.7ms [-6.27%, +1.79%]
  • ✔️010_tpch_02: 70.9ms -> 70.8ms [-1.71%, +1.6%]
  • ✔️010_tpch_03: 60.6ms -> 60.8ms [-1.3%, +1.97%]
  • ✔️010_tpch_04: 43.7ms -> 44.4ms [-1.18%, +4.16%]
  • ✔️010_tpch_05: 90.8ms -> 91.3ms [-1.28%, +2.44%]
  • ✔️010_tpch_06: 33.7ms -> 34.1ms [-9.4%, +11.45%]
  • ✔️010_tpch_07: 109ms -> 110ms [-1.17%, +3.85%]
  • 🚀010_tpch_08: 133ms -> 130ms [-3.8%, -0.13%]
  • ✔️010_tpch_09: 120ms -> 120ms [-4.69%, +5.05%]
  • ✔️010_tpch_10: 79.8ms -> 79.9ms [-3.61%, +3.8%]
  • ✔️010_tpch_11: 41.2ms -> 41ms [-5.35%, +4.79%]
  • ✔️010_tpch_12: 59.3ms -> 58.6ms [-3.6%, +1.09%]
  • ✔️010_tpch_13: 54.4ms -> 55.4ms [-1.76%, +5.57%]
  • ✔️010_tpch_14: 39.8ms -> 39.7ms [-2.79%, +2.56%]
  • ✔️010_tpch_15: 56.4ms -> 55.3ms [-10.09%, +6.32%]
  • ✔️010_tpch_16: 46.3ms -> 46.7ms [-1.93%, +3.87%]
  • ✔️010_tpch_17: 59.1ms -> 57.3ms [-8.13%, +2.23%]
  • ✔️010_tpch_18: 56.6ms -> 53.7ms [-10.96%, +0.87%]
  • ✔️010_tpch_19: 119ms -> 119ms [-2.19%, +1.21%]
  • ✔️010_tpch_20: 68.9ms -> 67.2ms [-5.06%, +0.23%]
  • ✔️010_tpch_21: 249ms -> 250ms [-2.42%, +3.55%]
  • ✔️010_tpch_22: 79ms -> 77.6ms [-4.43%, +0.88%]
  • ✔️100_tpch_01: 315ms -> 306ms [-20.56%, +15.15%]
  • ✔️100_tpch_02: 130ms -> 127ms [-7.62%, +3.11%]
  • ✔️100_tpch_03: 184ms -> 180ms [-9.14%, +4.35%]
  • ✔️100_tpch_04: 151ms -> 155ms [-6.82%, +11.82%]
  • ✔️100_tpch_05: 258ms -> 267ms [-7.99%, +14.48%]
  • ✔️100_tpch_06: 102ms -> 103ms [-2.4%, +4.14%]
  • ✔️100_tpch_07: 238ms -> 236ms [-11.14%, +9.83%]
  • ✔️100_tpch_08: 265ms -> 258ms [-11.6%, +5.85%]
  • ✔️100_tpch_09: 354ms -> 341ms [-15.73%, +8.12%]
  • ❗🐌100_tpch_10: 214ms -> 226ms [+0.85%, +10.82%]
  • ✔️100_tpch_11: 86.3ms -> 89.1ms [-10.9%, +17.24%]
  • ✔️100_tpch_12: 194ms -> 198ms [-12.23%, +16.62%]
  • ✔️100_tpch_13: 335ms -> 340ms [-6.12%, +9.28%]
  • ❗🐌100_tpch_14: 117ms -> 125ms [+0.8%, +13.25%]
  • ✔️100_tpch_15: 222ms -> 213ms [-19.07%, +10.78%]
  • ✔️100_tpch_16: 125ms -> 130ms [-1.94%, +9.49%]
  • ✔️100_tpch_17: 183ms -> 186ms [-7.96%, +10.74%]
  • ✔️100_tpch_18: 200ms -> 205ms [-4.94%, +10.47%]
  • ✔️100_tpch_19: 302ms -> 288ms [-17.23%, +8.16%]
  • ✔️100_tpch_20: 174ms -> 183ms [-4.45%, +15.23%]
  • ✔️100_tpch_21: 1.39s -> 1.35s [-9.14%, +3.29%]
  • ✔️100_tpch_22: 174ms -> 171ms [-5.39%, +2.28%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@krlmlr krlmlr force-pushed the f-216-fallback-config branch from 1d047ac to e5db7e9 Compare December 29, 2024 04:49
@krlmlr krlmlr merged commit b65e3d8 into main Dec 29, 2024
20 checks passed
@krlmlr krlmlr deleted the f-216-fallback-config branch December 29, 2024 05:06
@github-actions GitHub Actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if e5db7e9 is merged into main:

  • ✔️001_tpch_01: 23.3ms -> 24.1ms [-1.24%, +8.72%]
  • ✔️001_tpch_02: 68.1ms -> 68.2ms [-0.73%, +0.9%]
  • ✔️001_tpch_03: 40.1ms -> 40.6ms [-0.84%, +3%]
  • ✔️001_tpch_04: 22.7ms -> 22.2ms [-5.95%, +1.39%]
  • ✔️001_tpch_05: 56.9ms -> 56.7ms [-1.21%, +0.3%]
  • ✔️001_tpch_06: 13.9ms -> 14.1ms [-1.43%, +3.74%]
  • ❗🐌001_tpch_07: 74.2ms -> 74.7ms [+0.08%, +1.4%]
  • ✔️001_tpch_08: 98.7ms -> 99.6ms [-0.68%, +2.57%]
  • ✔️001_tpch_09: 76.5ms -> 76.5ms [-1.47%, +1.52%]
  • ✔️001_tpch_10: 49.2ms -> 49ms [-1.72%, +1.03%]
  • ✔️001_tpch_11: 33ms -> 33.1ms [-2.09%, +2.25%]
  • ✔️001_tpch_12: 27ms -> 27.2ms [-1.15%, +2.32%]
  • ✔️001_tpch_13: 25.2ms -> 25.2ms [-1.56%, +1.3%]
  • ✔️001_tpch_14: 19.9ms -> 20.1ms [-1.61%, +3.28%]
  • ✔️001_tpch_15: 31.4ms -> 31.3ms [-1.95%, +1.39%]
  • ✔️001_tpch_16: 39.9ms -> 40.3ms [-0.62%, +2.67%]
  • ✔️001_tpch_17: 26ms -> 26ms [-2.54%, +2.23%]
  • ✔️001_tpch_18: 22.5ms -> 22.3ms [-3.89%, +2.54%]
  • ✔️001_tpch_19: 66.7ms -> 67ms [-0.39%, +1.33%]
  • ✔️001_tpch_20: 50.9ms -> 50.8ms [-1.42%, +1.19%]
  • ✔️001_tpch_21: 78.9ms -> 79.2ms [-0.85%, +1.65%]
  • ✔️001_tpch_22: 66.8ms -> 66.9ms [-0.61%, +0.94%]
  • ✔️010_tpch_01: 80ms -> 80.2ms [-4.36%, +4.79%]
  • ✔️010_tpch_02: 72ms -> 72.3ms [-2.85%, +3.89%]
  • ✔️010_tpch_03: 61.6ms -> 61.3ms [-7.69%, +6.6%]
  • ✔️010_tpch_04: 42.7ms -> 44.5ms [-1.63%, +9.76%]
  • ✔️010_tpch_05: 92.9ms -> 91.3ms [-4.02%, +0.46%]
  • ✔️010_tpch_06: 34.4ms -> 33.3ms [-10.75%, +4.54%]
  • ✔️010_tpch_07: 109ms -> 109ms [-1.01%, +1.7%]
  • ✔️010_tpch_08: 131ms -> 131ms [-2.4%, +2.1%]
  • ✔️010_tpch_09: 117ms -> 117ms [-1.14%, +1.36%]
  • ✔️010_tpch_10: 76.7ms -> 75.4ms [-5.4%, +1.97%]
  • ✔️010_tpch_11: 40.8ms -> 40.3ms [-5.35%, +2.97%]
  • ✔️010_tpch_12: 59.9ms -> 60.2ms [-8.29%, +9.21%]
  • ✔️010_tpch_13: 53.8ms -> 53.3ms [-3.64%, +1.75%]
  • ✔️010_tpch_14: 38.6ms -> 38.6ms [-1.35%, +1.22%]
  • ✔️010_tpch_15: 56ms -> 55ms [-8.19%, +4.6%]
  • ✔️010_tpch_16: 45.4ms -> 45.3ms [-2.95%, +2.65%]
  • ✔️010_tpch_17: 58.6ms -> 59.5ms [-8.97%, +12.1%]
  • ✔️010_tpch_18: 53.3ms -> 51.4ms [-9.23%, +2.34%]
  • ✔️010_tpch_19: 118ms -> 118ms [-1.88%, +2%]
  • ✔️010_tpch_20: 69.2ms -> 67.9ms [-7.58%, +3.85%]
  • ✔️010_tpch_21: 242ms -> 243ms [-2.45%, +3.46%]
  • ✔️010_tpch_22: 76.3ms -> 76.6ms [-1.68%, +2.48%]
  • ✔️100_tpch_01: 329ms -> 324ms [-5.22%, +2.2%]
  • ✔️100_tpch_02: 137ms -> 125ms [-26.98%, +8.6%]
  • ✔️100_tpch_03: 173ms -> 184ms [-2.07%, +14.78%]
  • ✔️100_tpch_04: 155ms -> 155ms [-3.31%, +3.18%]
  • ✔️100_tpch_05: 284ms -> 273ms [-16.77%, +8.64%]
  • ✔️100_tpch_06: 110ms -> 104ms [-34.31%, +23.08%]
  • ✔️100_tpch_07: 243ms -> 242ms [-8.99%, +8.27%]
  • ✔️100_tpch_08: 260ms -> 268ms [-6.15%, +12.24%]
  • ✔️100_tpch_09: 345ms -> 343ms [-15.76%, +15%]
  • ✔️100_tpch_10: 219ms -> 224ms [-7.52%, +12.46%]
  • ✔️100_tpch_11: 85.4ms -> 86.6ms [-8.13%, +10.77%]
  • ❗🐌100_tpch_12: 182ms -> 200ms [+8.04%, +12.23%]
  • ✔️100_tpch_13: 314ms -> 318ms [-5.37%, +7.86%]
  • ✔️100_tpch_14: 129ms -> 137ms [-5.69%, +19.19%]
  • ✔️100_tpch_15: 223ms -> 227ms [-14.37%, +17.49%]
  • ✔️100_tpch_16: 130ms -> 126ms [-9.93%, +3.34%]
  • ✔️100_tpch_17: 182ms -> 175ms [-10.96%, +3.58%]
  • ✔️100_tpch_18: 204ms -> 193ms [-12.79%, +1.18%]
  • ✔️100_tpch_19: 289ms -> 290ms [-15.48%, +16.1%]
  • ✔️100_tpch_20: 174ms -> 182ms [-4.84%, +13.87%]
  • ✔️100_tpch_21: 1.32s -> 1.3s [-7.27%, +4.87%]
  • ✔️100_tpch_22: 176ms -> 169ms [-12.87%, +4.85%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadley hadley Awaiting requested review from hadley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Easier way to enable fallback reporting?
1 participant
@krlmlr