Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fallback logging is now on by default, can be disabled with configuration #422

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Dec 27, 2024

For #216.

@krlmlr krlmlr enabled auto-merge (squash) December 27, 2024 11:28
@krlmlr krlmlr requested a review from maelle December 27, 2024 11:28
@krlmlr krlmlr merged commit 672cef5 into main Dec 27, 2024
20 checks passed
@krlmlr krlmlr deleted the f-opt-out-logging branch December 27, 2024 11:45
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 9f97310 is merged into main:

  • 🚀001_tpch_01: 25.9ms -> 24.8ms [-8.01%, -0.49%]
  • 🚀001_tpch_02: 180ms -> 74.7ms [-59.83%, -57.12%]
  • 🚀001_tpch_03: 68.6ms -> 40.7ms [-43.07%, -38.23%]
  • ✔️001_tpch_04: 22.2ms -> 22.5ms [-0.87%, +3.97%]
  • 🚀001_tpch_05: 156ms -> 58.5ms [-63.96%, -61.08%]
  • 🚀001_tpch_06: 21.3ms -> 15.2ms [-31.09%, -25.62%]
  • 🚀001_tpch_07: 144ms -> 76.8ms [-48.17%, -45.35%]
  • 🚀001_tpch_08: 160ms -> 98.9ms [-39.42%, -37.12%]
  • 🚀001_tpch_09: 175ms -> 76.7ms [-57.55%, -55.07%]
  • 🚀001_tpch_10: 75.5ms -> 50.2ms [-35.33%, -31.71%]
  • ✔️001_tpch_11: 33.9ms -> 33.2ms [-4.46%, +0.03%]
  • ✔️001_tpch_12: 27.9ms -> 27.5ms [-3.22%, +0.41%]
  • ❗🐌001_tpch_13: 25.1ms -> 25.8ms [+0.79%, +5.17%]
  • 🚀001_tpch_14: 27.5ms -> 21.2ms [-24.87%, -21.06%]
  • ✔️001_tpch_15: 32.9ms -> 32.6ms [-2.49%, +0.9%]
  • 🚀001_tpch_16: 69.9ms -> 41.5ms [-41.77%, -39.42%]
  • 🚀001_tpch_17: 27.2ms -> 26.7ms [-2.53%, -0.63%]
  • ✔️001_tpch_18: 23.3ms -> 23.1ms [-3.17%, +1.49%]
  • 🚀001_tpch_19: 69.6ms -> 68.5ms [-2.57%, -0.46%]
  • 🚀001_tpch_20: 78.3ms -> 51.2ms [-36.07%, -33.24%]
  • 🚀001_tpch_21: 105ms -> 80.2ms [-24.78%, -22.42%]
  • 🚀001_tpch_22: 94.5ms -> 67.7ms [-29.63%, -27.11%]
  • ✔️010_tpch_01: 81.6ms -> 82.7ms [-6.03%, +8.54%]
  • ✔️010_tpch_02: 75ms -> 74ms [-4.26%, +1.67%]
  • ✔️010_tpch_03: 62.9ms -> 62.5ms [-3.69%, +2.44%]
  • ✔️010_tpch_04: 44.2ms -> 45.6ms [-1.72%, +8.15%]
  • ✔️010_tpch_05: 93.9ms -> 94.2ms [-2.41%, +3.1%]
  • ✔️010_tpch_06: 34.7ms -> 34.8ms [-5.85%, +6.16%]
  • ✔️010_tpch_07: 112ms -> 112ms [-4.09%, +3.03%]
  • ✔️010_tpch_08: 136ms -> 133ms [-5.92%, +0.88%]
  • ✔️010_tpch_09: 119ms -> 119ms [-1.6%, +1.16%]
  • ✔️010_tpch_10: 81ms -> 77.6ms [-10.35%, +1.82%]
  • 🚀010_tpch_11: 41ms -> 39.5ms [-5.71%, -1.77%]
  • ✔️010_tpch_12: 58.9ms -> 61.5ms [-1.78%, +10.34%]
  • ✔️010_tpch_13: 56.3ms -> 54.6ms [-9.69%, +3.58%]
  • ✔️010_tpch_14: 39.4ms -> 41.1ms [-2.03%, +10.86%]
  • ✔️010_tpch_15: 56.3ms -> 55.5ms [-7.62%, +4.88%]
  • ✔️010_tpch_16: 47.9ms -> 47ms [-4.12%, +0.27%]
  • ✔️010_tpch_17: 58.1ms -> 57.4ms [-8.15%, +5.87%]
  • ✔️010_tpch_18: 55.2ms -> 53.5ms [-10.22%, +4.06%]
  • ✔️010_tpch_19: 120ms -> 120ms [-1.77%, +2.17%]
  • ✔️010_tpch_20: 72.8ms -> 71.4ms [-7.6%, +3.76%]
  • ✔️010_tpch_21: 248ms -> 249ms [-1.82%, +2.86%]
  • ✔️010_tpch_22: 80ms -> 79.4ms [-1.88%, +0.36%]
  • ✔️100_tpch_01: 313ms -> 312ms [-21.46%, +21.26%]
  • ✔️100_tpch_02: 124ms -> 126ms [-1.64%, +3.73%]
  • ✔️100_tpch_03: 182ms -> 181ms [-2.6%, +1.55%]
  • ✔️100_tpch_04: 146ms -> 149ms [-9.59%, +12.9%]
  • ✔️100_tpch_05: 262ms -> 268ms [-11.84%, +16.84%]
  • ✔️100_tpch_06: 100ms -> 101ms [-7.22%, +9.56%]
  • ✔️100_tpch_07: 246ms -> 240ms [-13.66%, +9.08%]
  • ✔️100_tpch_08: 269ms -> 265ms [-16.61%, +13.36%]
  • ✔️100_tpch_09: 333ms -> 342ms [-6.91%, +12.2%]
  • ✔️100_tpch_10: 220ms -> 217ms [-5.89%, +2.79%]
  • ✔️100_tpch_11: 84.8ms -> 87.4ms [-9.01%, +15.13%]
  • ✔️100_tpch_12: 208ms -> 190ms [-20.76%, +3.58%]
  • ✔️100_tpch_13: 349ms -> 337ms [-12.24%, +5.48%]
  • ✔️100_tpch_14: 125ms -> 125ms [-4.94%, +5.32%]
  • ✔️100_tpch_15: 211ms -> 219ms [-9.92%, +17.32%]
  • ❗🐌100_tpch_16: 129ms -> 143ms [+1.13%, +20.45%]
  • ✔️100_tpch_17: 185ms -> 192ms [-4.91%, +12.36%]
  • ✔️100_tpch_18: 199ms -> 198ms [-7.08%, +5.65%]
  • ✔️100_tpch_19: 285ms -> 306ms [-6.12%, +20.58%]
  • ✔️100_tpch_20: 187ms -> 185ms [-9.79%, +7.56%]
  • ✔️100_tpch_21: 1.34s -> 1.34s [-5.53%, +5.87%]
  • ✔️100_tpch_22: 181ms -> 175ms [-15.97%, +9.35%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant