Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New duckparquet(), duckcsv(), duckjson() and duckfile(), deprecating duckplyr_df_from_*() and df_from_*() functions #396

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Dec 16, 2024

Closes #210.

@krlmlr krlmlr changed the title f 210 io feat: New duckparquet(), duckcsv(), duckjson() and duckfile(), deprecating duckplyr_df_from_*() and df_from_*() functions Dec 16, 2024
@krlmlr krlmlr enabled auto-merge (squash) December 16, 2024 06:06
…, deprecating `duckplyr_df_from_*()` and `df_from_*()` functions
@krlmlr krlmlr merged commit e55eff3 into main Dec 16, 2024
19 checks passed
@krlmlr krlmlr deleted the f-210-io branch December 16, 2024 06:31
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if cb032cb is merged into main:

  • 🚀001_tpch_01: 25.2ms -> 24.2ms [-7.8%, -0.44%]
  • ✔️001_tpch_02: 134ms -> 133ms [-1.58%, +0.57%]
  • ✔️001_tpch_03: 70.1ms -> 71ms [-0.58%, +3.09%]
  • ✔️001_tpch_04: 22.9ms -> 23.1ms [-1.15%, +2.89%]
  • ✔️001_tpch_05: 122ms -> 123ms [-1.08%, +1.64%]
  • ✔️001_tpch_06: 14.5ms -> 14.3ms [-4.26%, +2.24%]
  • ✔️001_tpch_07: 141ms -> 142ms [-0.62%, +1.48%]
  • ✔️001_tpch_08: 92.9ms -> 92.5ms [-1.29%, +0.45%]
  • ✔️001_tpch_09: 135ms -> 135ms [-1.28%, +1.28%]
  • ✔️001_tpch_10: 114ms -> 114ms [-1.42%, +1.08%]
  • ✔️001_tpch_11: 66.8ms -> 67ms [-1.42%, +1.81%]
  • ✔️001_tpch_12: 61.8ms -> 61.1ms [-3.51%, +1.31%]
  • ❗🐌001_tpch_13: 19.9ms -> 20.6ms [+0.4%, +6.75%]
  • ✔️001_tpch_14: 20.5ms -> 20.6ms [-1.16%, +2.23%]
  • ✔️001_tpch_15: 64.3ms -> 64.3ms [-1.57%, +1.69%]
  • ✔️001_tpch_16: 66.8ms -> 67.2ms [-0.91%, +2.17%]
  • ✔️001_tpch_17: 58.6ms -> 58.3ms [-2.72%, +1.62%]
  • 🚀001_tpch_18: 23.1ms -> 22.6ms [-4.49%, -0.08%]
  • ✔️001_tpch_19: 132ms -> 133ms [-0.36%, +1.94%]
  • ✔️001_tpch_20: 80.3ms -> 80.4ms [-1.58%, +1.85%]
  • ✔️001_tpch_21: 144ms -> 144ms [-1.25%, +1.65%]
  • ✔️001_tpch_22: 128ms -> 128ms [-0.95%, +1.04%]
  • ✔️010_tpch_01: 81.8ms -> 81.7ms [-6.19%, +6%]
  • ✔️010_tpch_02: 71ms -> 72ms [-0.3%, +3.01%]
  • ✔️010_tpch_03: 61ms -> 62.7ms [-1.56%, +6.99%]
  • ✔️010_tpch_04: 43.7ms -> 44.7ms [-2.48%, +6.79%]
  • ✔️010_tpch_05: 92.3ms -> 94.1ms [-1.01%, +4.93%]
  • ✔️010_tpch_06: 32.9ms -> 32.1ms [-8.17%, +2.82%]
  • ✔️010_tpch_07: 108ms -> 108ms [-1.18%, +1.04%]
  • ✔️010_tpch_08: 130ms -> 131ms [-2.77%, +3.96%]
  • ✔️010_tpch_09: 118ms -> 117ms [-1.73%, +0.87%]
  • ✔️010_tpch_10: 76.8ms -> 76.3ms [-2.98%, +1.81%]
  • ✔️010_tpch_11: 38.4ms -> 38.8ms [-1.72%, +3.94%]
  • ✔️010_tpch_12: 57.3ms -> 57.6ms [-0.15%, +1.12%]
  • ✔️010_tpch_13: 53ms -> 53ms [-1.87%, +2.05%]
  • ✔️010_tpch_14: 38.8ms -> 38.8ms [-5.39%, +5.27%]
  • ✔️010_tpch_15: 55.1ms -> 57.5ms [-1.86%, +10.54%]
  • ✔️010_tpch_16: 46.5ms -> 45.9ms [-4.21%, +1.57%]
  • ✔️010_tpch_17: 55ms -> 55.6ms [-1.77%, +3.95%]
  • ✔️010_tpch_18: 52.9ms -> 54.8ms [-2.57%, +9.66%]
  • ✔️010_tpch_19: 118ms -> 120ms [-1.08%, +4.44%]
  • ✔️010_tpch_20: 69.5ms -> 70.1ms [-2.31%, +3.95%]
  • ✔️010_tpch_21: 241ms -> 243ms [-3.06%, +4.42%]
  • ✔️010_tpch_22: 81.3ms -> 80.5ms [-5.64%, +3.79%]
  • ✔️100_tpch_01: 331ms -> 319ms [-19.41%, +11.9%]
  • ✔️100_tpch_02: 134ms -> 129ms [-16.14%, +9.51%]
  • ✔️100_tpch_03: 180ms -> 192ms [-6.44%, +19.59%]
  • ✔️100_tpch_04: 155ms -> 156ms [-6.16%, +8.15%]
  • ✔️100_tpch_05: 275ms -> 258ms [-13.25%, +0.74%]
  • ✔️100_tpch_06: 107ms -> 109ms [-15.36%, +18.2%]
  • ✔️100_tpch_07: 236ms -> 238ms [-8.22%, +10.21%]
  • ✔️100_tpch_08: 266ms -> 267ms [-7.16%, +8.05%]
  • ✔️100_tpch_09: 335ms -> 354ms [-7.24%, +18.57%]
  • ✔️100_tpch_10: 225ms -> 218ms [-16.46%, +10.07%]
  • ✔️100_tpch_11: 83.5ms -> 87.9ms [-13.77%, +24.34%]
  • ✔️100_tpch_12: 200ms -> 191ms [-12.46%, +3.87%]
  • ✔️100_tpch_13: 310ms -> 317ms [-2.22%, +7.11%]
  • ✔️100_tpch_14: 121ms -> 124ms [-13.42%, +19.4%]
  • ✔️100_tpch_15: 217ms -> 214ms [-10.25%, +8.04%]
  • ✔️100_tpch_16: 129ms -> 134ms [-21.1%, +28.8%]
  • ✔️100_tpch_17: 180ms -> 178ms [-18.56%, +15.42%]
  • ✔️100_tpch_18: 194ms -> 197ms [-11.79%, +14.83%]
  • ✔️100_tpch_19: 292ms -> 286ms [-13.19%, +9.55%]
  • ✔️100_tpch_20: 175ms -> 181ms [-7.44%, +14%]
  • ✔️100_tpch_21: 1.32s -> 1.29s [-6.5%, +1.16%]
  • ✔️100_tpch_22: 170ms -> 170ms [-3.68%, +3.43%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better names for duckplyr_df_from_csv() and duckplyr_df_from_parquet()
1 participant