Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Deprecate is_duckplyr_df() #392

Merged
merged 1 commit into from
Dec 16, 2024
Merged

feat: Deprecate is_duckplyr_df() #392

merged 1 commit into from
Dec 16, 2024

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Dec 15, 2024 •
edited
Loading

No description provided.

@krlmlr krlmlr changed the title f deprecate feat: Deprecate is_duckplyr_df() Dec 15, 2024
@krlmlr krlmlr enabled auto-merge (squash) December 15, 2024 20:29
@github-actions GitHub Actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 8e3afe0 is merged into main:

  • ✔️001_tpch_01: 26.1ms -> 25.8ms [-4.59%, +2.86%]
  • ✔️001_tpch_02: 137ms -> 135ms [-2.17%, +0.06%]
  • 🚀001_tpch_03: 71.9ms -> 69.9ms [-4.35%, -1.13%]
  • 🚀001_tpch_04: 24.8ms -> 23.6ms [-6.1%, -3.66%]
  • ✔️001_tpch_05: 129ms -> 128ms [-1.7%, +0.08%]
  • 🚀001_tpch_06: 15.6ms -> 15ms [-6.62%, -1.8%]
  • 🚀001_tpch_07: 148ms -> 146ms [-2.47%, -0.55%]
  • 🚀001_tpch_08: 96.5ms -> 94.5ms [-3.02%, -1.09%]
  • ✔️001_tpch_09: 139ms -> 138ms [-1.85%, +0.63%]
  • ✔️001_tpch_10: 119ms -> 118ms [-1.84%, +0.23%]
  • ✔️001_tpch_11: 69ms -> 68.9ms [-1.63%, +1.21%]
  • ✔️001_tpch_12: 64.1ms -> 63.1ms [-3.19%, +0.25%]
  • ✔️001_tpch_13: 21.3ms -> 21.3ms [-3.52%, +3.64%]
  • 🚀001_tpch_14: 22.4ms -> 21.2ms [-7.16%, -3.36%]
  • ✔️001_tpch_15: 69.2ms -> 68.8ms [-2.36%, +1.16%]
  • ✔️001_tpch_16: 71.2ms -> 71ms [-2.31%, +1.66%]
  • 🚀001_tpch_17: 62.7ms -> 61.8ms [-2.71%, -0.26%]
  • 🚀001_tpch_18: 24.8ms -> 23.4ms [-7.48%, -3.72%]
  • 🚀001_tpch_19: 138ms -> 136ms [-2.63%, -0.36%]
  • ✔️001_tpch_20: 84ms -> 83.7ms [-1.57%, +0.85%]
  • 🚀001_tpch_21: 153ms -> 151ms [-2.49%, -0.2%]
  • ✔️001_tpch_22: 138ms -> 137ms [-1.81%, +0.58%]
  • ✔️010_tpch_01: 85.5ms -> 81.4ms [-9.6%, 0%]
  • ✔️010_tpch_02: 74.8ms -> 74.3ms [-2.6%, +1.07%]
  • 🚀010_tpch_03: 67.7ms -> 62.8ms [-9.71%, -4.83%]
  • 🚀010_tpch_04: 47.9ms -> 44.2ms [-10.27%, -5.36%]
  • 🚀010_tpch_05: 99.1ms -> 93.7ms [-7.09%, -3.74%]
  • 🚀010_tpch_06: 37.3ms -> 33.9ms [-16.01%, -2.54%]
  • 🚀010_tpch_07: 115ms -> 109ms [-5.58%, -3.52%]
  • 🚀010_tpch_08: 137ms -> 132ms [-4.67%, -2.78%]
  • 🚀010_tpch_09: 125ms -> 121ms [-6.04%, -1.14%]
  • 🚀010_tpch_10: 82.8ms -> 78.1ms [-7.59%, -3.97%]
  • 🚀010_tpch_11: 42.2ms -> 39.8ms [-10.77%, -0.63%]
  • ✔️010_tpch_12: 61.8ms -> 59ms [-9.41%, +0.53%]
  • ✔️010_tpch_13: 53.8ms -> 54.2ms [-1.18%, +2.41%]
  • 🚀010_tpch_14: 41.3ms -> 38.6ms [-7.77%, -5.12%]
  • 🚀010_tpch_15: 61.6ms -> 56.4ms [-12.99%, -3.84%]
  • ✔️010_tpch_16: 48ms -> 46.5ms [-6.68%, +0.06%]
  • 🚀010_tpch_17: 60.3ms -> 57.4ms [-9.12%, -0.61%]
  • ✔️010_tpch_18: 54.2ms -> 54.4ms [-2.98%, +3.85%]
  • 🚀010_tpch_19: 123ms -> 118ms [-6.29%, -2.03%]
  • 🚀010_tpch_20: 75.9ms -> 69.6ms [-10.85%, -5.66%]
  • 🚀010_tpch_21: 396ms -> 245ms [-39.75%, -36.5%]
  • ✔️010_tpch_22: 80.1ms -> 80.1ms [-1.65%, +1.66%]
  • 🚀100_tpch_01: 1.22s -> 311ms [-78.64%, -70.15%]
  • ✔️100_tpch_02: 132ms -> 129ms [-7.34%, +2.67%]
  • 🚀100_tpch_03: 1.12s -> 181ms [-85.03%, -82.84%]
  • 🚀100_tpch_04: 1.09s -> 157ms [-88.47%, -82.9%]
  • 🚀100_tpch_05: 1.23s -> 288ms [-78.74%, -74.27%]
  • 🚀100_tpch_06: 1.05s -> 104ms [-95.4%, -84.63%]
  • 🚀100_tpch_07: 1.16s -> 250ms [-79.02%, -77.76%]
  • 🚀100_tpch_08: 1.18s -> 273ms [-78.74%, -74.91%]
  • 🚀100_tpch_09: 1.27s -> 347ms [-76.71%, -68.85%]
  • 🚀100_tpch_10: 1.14s -> 215ms [-82.9%, -79.18%]
  • ✔️100_tpch_11: 87ms -> 88.5ms [-4.79%, +8.24%]
  • 🚀100_tpch_12: 1.12s -> 194ms [-86.22%, -79.06%]
  • 🚀100_tpch_13: 350ms -> 326ms [-9.64%, -3.96%]
  • 🚀100_tpch_14: 1.04s -> 122ms [-92.05%, -84.53%]
  • 🚀100_tpch_15: 1.12s -> 230ms [-82.51%, -76.37%]
  • ✔️100_tpch_16: 127ms -> 126ms [-7.55%, +6.61%]
  • 🚀100_tpch_17: 1.09s -> 171ms [-86.11%, -82.65%]
  • 🚀100_tpch_18: 1.13s -> 211ms [-83.29%, -79.28%]
  • 🚀100_tpch_19: 1.21s -> 297ms [-78.1%, -72.94%]
  • 🚀100_tpch_20: 1.1s -> 189ms [-85.18%, -80.59%]
  • 🚀100_tpch_21: 2.3s -> 1.32s [-47.15%, -37.56%]
  • ✔️100_tpch_22: 176ms -> 173ms [-6.92%, +3.25%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@krlmlr krlmlr disabled auto-merge December 16, 2024 02:51
@krlmlr krlmlr enabled auto-merge (squash) December 16, 2024 03:51
@krlmlr krlmlr merged commit 9107b5e into main Dec 16, 2024
19 checks passed
@krlmlr krlmlr deleted the f-deprecate branch December 16, 2024 04:34
@github-actions GitHub Actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 7e257b6 is merged into main:

  • ✔️001_tpch_01: 24.5ms -> 24.2ms [-5.45%, +2.8%]
  • ✔️001_tpch_02: 132ms -> 132ms [-2.02%, +1.88%]
  • ✔️001_tpch_03: 68.8ms -> 68.9ms [-2.81%, +3.28%]
  • ✔️001_tpch_04: 22.9ms -> 23ms [-1.49%, +2.27%]
  • ✔️001_tpch_05: 122ms -> 124ms [-0.73%, +3.16%]
  • 🚀001_tpch_06: 14.6ms -> 14ms [-7.07%, -1.13%]
  • ✔️001_tpch_07: 142ms -> 144ms [-0.71%, +2.46%]
  • ✔️001_tpch_08: 92.4ms -> 92.8ms [-0.93%, +1.8%]
  • ✔️001_tpch_09: 134ms -> 136ms [-0.53%, +3.85%]
  • ✔️001_tpch_10: 114ms -> 115ms [-1.45%, +2.22%]
  • ❗🐌001_tpch_11: 65.5ms -> 67.4ms [+0.5%, +5.45%]
  • ❗🐌001_tpch_12: 60.5ms -> 62.8ms [+0.9%, +6.84%]
  • ✔️001_tpch_13: 20.1ms -> 20.2ms [-2.02%, +3.25%]
  • ✔️001_tpch_14: 20.9ms -> 20.6ms [-4.12%, +1.36%]
  • ✔️001_tpch_15: 66ms -> 66.2ms [-2.57%, +3.29%]
  • ✔️001_tpch_16: 68.8ms -> 68.1ms [-3.87%, +2.07%]
  • ✔️001_tpch_17: 59.5ms -> 59.4ms [-3.55%, +3.34%]
  • ✔️001_tpch_18: 22.7ms -> 23.3ms [-0.77%, +5.67%]
  • ✔️001_tpch_19: 132ms -> 130ms [-3.78%, +0.12%]
  • ✔️001_tpch_20: 79.2ms -> 79.8ms [-2.47%, +3.85%]
  • ✔️001_tpch_21: 146ms -> 144ms [-2.84%, +0.7%]
  • ✔️001_tpch_22: 127ms -> 129ms [-0.67%, +3.83%]
  • 🚀010_tpch_01: 86ms -> 80.3ms [-12.01%, -1.26%]
  • ✔️010_tpch_02: 72.7ms -> 72.4ms [-3.3%, +2.29%]
  • ✔️010_tpch_03: 61.3ms -> 62.5ms [-2.87%, +6.68%]
  • ✔️010_tpch_04: 44ms -> 44.4ms [-1.81%, +3.75%]
  • ✔️010_tpch_05: 93ms -> 92.5ms [-2.54%, +1.45%]
  • ✔️010_tpch_06: 31.9ms -> 34.5ms [-0.73%, +16.89%]
  • ✔️010_tpch_07: 108ms -> 108ms [-3.28%, +3.63%]
  • ✔️010_tpch_08: 130ms -> 132ms [-0.34%, +3.5%]
  • ✔️010_tpch_09: 118ms -> 117ms [-2.69%, +1.22%]
  • ✔️010_tpch_10: 76.3ms -> 76.6ms [-1.74%, +2.4%]
  • ✔️010_tpch_11: 39.1ms -> 39.3ms [-4.39%, +5.18%]
  • ✔️010_tpch_12: 58.5ms -> 58ms [-3.16%, +1.57%]
  • ✔️010_tpch_13: 53.5ms -> 53.9ms [-3.15%, +4.58%]
  • ✔️010_tpch_14: 37.8ms -> 40ms [-0.78%, +12.39%]
  • ✔️010_tpch_15: 55.4ms -> 57.1ms [-4.2%, +10.14%]
  • ✔️010_tpch_16: 46.8ms -> 45.8ms [-6.95%, +2.55%]
  • ✔️010_tpch_17: 54.3ms -> 55.1ms [-0.72%, +3.62%]
  • ✔️010_tpch_18: 55.1ms -> 54.4ms [-9.53%, +6.9%]
  • ✔️010_tpch_19: 118ms -> 119ms [-2%, +3.63%]
  • ✔️010_tpch_20: 68.8ms -> 68.1ms [-3.74%, +1.81%]
  • ✔️010_tpch_21: 241ms -> 246ms [-1%, +4.76%]
  • ✔️010_tpch_22: 78.4ms -> 77.5ms [-3.22%, +0.91%]
  • ✔️100_tpch_01: 336ms -> 327ms [-6.57%, +1.43%]
  • ✔️100_tpch_02: 125ms -> 127ms [-4.24%, +7.37%]
  • ✔️100_tpch_03: 185ms -> 175ms [-13.89%, +3.9%]
  • ✔️100_tpch_04: 149ms -> 156ms [-4.59%, +13.25%]
  • ✔️100_tpch_05: 266ms -> 274ms [-10.32%, +15.88%]
  • ✔️100_tpch_06: 103ms -> 100ms [-12.19%, +6.72%]
  • ✔️100_tpch_07: 236ms -> 241ms [-4.99%, +8.97%]
  • ✔️100_tpch_08: 267ms -> 264ms [-17.33%, +14.93%]
  • ✔️100_tpch_09: 353ms -> 336ms [-15.01%, +5.57%]
  • 🚀100_tpch_10: 223ms -> 213ms [-9.32%, -0.16%]
  • ✔️100_tpch_11: 93.3ms -> 88.8ms [-26.91%, +17.25%]
  • ✔️100_tpch_12: 191ms -> 189ms [-13.84%, +11.54%]
  • ✔️100_tpch_13: 322ms -> 319ms [-12.04%, +9.84%]
  • ✔️100_tpch_14: 132ms -> 126ms [-25.56%, +15.38%]
  • ✔️100_tpch_15: 228ms -> 226ms [-7.5%, +6.09%]
  • ✔️100_tpch_16: 124ms -> 124ms [-4.49%, +4.29%]
  • ✔️100_tpch_17: 186ms -> 181ms [-14.41%, +9.56%]
  • ✔️100_tpch_18: 199ms -> 194ms [-13.84%, +8.76%]
  • ✔️100_tpch_19: 316ms -> 285ms [-19.96%, +0.7%]
  • ✔️100_tpch_20: 175ms -> 179ms [-3.64%, +8.68%]
  • ✔️100_tpch_21: 1.34s -> 1.31s [-11.34%, +7.74%]
  • ✔️100_tpch_22: 178ms -> 170ms [-9.88%, +1.55%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@krlmlr