Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: New is_ducktbl() #391

Merged
merged 1 commit into from
Dec 16, 2024
Merged

feat: New is_ducktbl() #391

merged 1 commit into from
Dec 16, 2024

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Dec 15, 2024 •
edited
Loading

No description provided.

@krlmlr krlmlr changed the title f is ducktbl feat: New is_ducktbl() Dec 15, 2024
@krlmlr krlmlr enabled auto-merge (squash) December 15, 2024 20:17
@github-actions GitHub Actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 8a2993d is merged into main:

  • 🚀001_tpch_01: 24.3ms -> 23.3ms [-8.54%, -0.28%]
  • ✔️001_tpch_02: 124ms -> 124ms [-1.19%, +0.57%]
  • 🚀001_tpch_03: 64.8ms -> 63.3ms [-3.77%, -1.07%]
  • 🚀001_tpch_04: 23.4ms -> 21.9ms [-7.2%, -5.74%]
  • 🚀001_tpch_05: 119ms -> 117ms [-2.46%, -0.64%]
  • 🚀001_tpch_06: 14.7ms -> 13.7ms [-8.63%, -4.59%]
  • ✔️001_tpch_07: 140ms -> 139ms [-1.62%, +0.32%]
  • 🚀001_tpch_08: 93.9ms -> 91ms [-4.02%, -2.14%]
  • 🚀001_tpch_09: 129ms -> 127ms [-2.63%, -0.99%]
  • 🚀001_tpch_10: 109ms -> 108ms [-2.19%, -0.36%]
  • ✔️001_tpch_11: 62.5ms -> 62ms [-2.35%, +0.79%]
  • 🚀001_tpch_12: 57.2ms -> 56.3ms [-3.06%, -0.16%]
  • 🚀001_tpch_13: 19.7ms -> 19.2ms [-4.69%, -0.59%]
  • 🚀001_tpch_14: 21ms -> 19.8ms [-6.63%, -4.92%]
  • ✔️001_tpch_15: 62.3ms -> 61.5ms [-3.07%, +0.36%]
  • ✔️001_tpch_16: 64.5ms -> 64.4ms [-1.69%, +1.24%]
  • ✔️001_tpch_17: 56.4ms -> 55.6ms [-3.48%, +0.55%]
  • 🚀001_tpch_18: 23.2ms -> 22.2ms [-6.02%, -2.73%]
  • ✔️001_tpch_19: 127ms -> 126ms [-1.44%, +0.35%]
  • 🚀001_tpch_20: 77.5ms -> 75ms [-4.65%, -1.62%]
  • 🚀001_tpch_21: 142ms -> 139ms [-3.11%, -0.89%]
  • ✔️001_tpch_22: 123ms -> 123ms [-1.31%, +1.04%]
  • 🚀010_tpch_01: 84.7ms -> 80.7ms [-8.73%, -0.75%]
  • ✔️010_tpch_02: 71.5ms -> 72.2ms [-0.69%, +2.6%]
  • 🚀010_tpch_03: 65.7ms -> 60.1ms [-11.16%, -5.98%]
  • 🚀010_tpch_04: 47.2ms -> 43.3ms [-10.67%, -6.08%]
  • 🚀010_tpch_05: 95ms -> 91ms [-5.51%, -2.96%]
  • 🚀010_tpch_06: 36.2ms -> 32.8ms [-18.66%, -0.21%]
  • 🚀010_tpch_07: 111ms -> 106ms [-5.5%, -3.13%]
  • 🚀010_tpch_08: 133ms -> 127ms [-5.63%, -2.41%]
  • 🚀010_tpch_09: 121ms -> 116ms [-5.13%, -2.67%]
  • 🚀010_tpch_10: 80ms -> 77.3ms [-6.37%, -0.47%]
  • ✔️010_tpch_11: 38.7ms -> 38.2ms [-4.82%, +2.24%]
  • 🚀010_tpch_12: 60.3ms -> 57.6ms [-6.98%, -1.95%]
  • ✔️010_tpch_13: 52.4ms -> 52.1ms [-1.78%, +0.55%]
  • 🚀010_tpch_14: 42ms -> 37.7ms [-17.75%, -2.66%]
  • ✔️010_tpch_15: 58.6ms -> 55.3ms [-12.35%, +1.17%]
  • ✔️010_tpch_16: 45.7ms -> 45.2ms [-3.5%, +1.13%]
  • 🚀010_tpch_17: 57.1ms -> 54.2ms [-6.06%, -3.84%]
  • ✔️010_tpch_18: 58.8ms -> 54.8ms [-15.33%, +1.76%]
  • 🚀010_tpch_19: 120ms -> 116ms [-4.29%, -2.56%]
  • 🚀010_tpch_20: 72.8ms -> 67.9ms [-10.75%, -2.71%]
  • 🚀010_tpch_21: 386ms -> 236ms [-40.3%, -37.38%]
  • 🚀010_tpch_22: 78.2ms -> 76.2ms [-3.73%, -1.41%]
  • 🚀100_tpch_01: 1.19s -> 334ms [-78.94%, -64.88%]
  • ✔️100_tpch_02: 129ms -> 125ms [-8.74%, +2.75%]
  • 🚀100_tpch_03: 1.06s -> 181ms [-85.77%, -80.12%]
  • 🚀100_tpch_04: 1.04s -> 155ms [-86.84%, -83.22%]
  • 🚀100_tpch_05: 1.16s -> 254ms [-82.33%, -73.68%]
  • 🚀100_tpch_06: 986ms -> 100ms [-91.87%, -87.81%]
  • 🚀100_tpch_07: 1.11s -> 230ms [-82.09%, -76.71%]
  • 🚀100_tpch_08: 1.15s -> 276ms [-77.78%, -74.18%]
  • 🚀100_tpch_09: 1.22s -> 340ms [-76.5%, -67.82%]
  • 🚀100_tpch_10: 1.08s -> 216ms [-81.06%, -78.74%]
  • ✔️100_tpch_11: 82.7ms -> 87.4ms [-9.28%, +20.66%]
  • 🚀100_tpch_12: 1.08s -> 189ms [-85.52%, -79.6%]
  • ✔️100_tpch_13: 313ms -> 314ms [-5.23%, +6.23%]
  • 🚀100_tpch_14: 993ms -> 123ms [-89.09%, -86.24%]
  • 🚀100_tpch_15: 1.11s -> 213ms [-82.6%, -79.12%]
  • ✔️100_tpch_16: 123ms -> 138ms [-7.72%, +31.29%]
  • 🚀100_tpch_17: 1.07s -> 180ms [-84.38%, -82%]
  • 🚀100_tpch_18: 1.09s -> 202ms [-83.21%, -79.84%]
  • 🚀100_tpch_19: 1.16s -> 297ms [-76.21%, -72.66%]
  • 🚀100_tpch_20: 1.07s -> 186ms [-85.57%, -79.83%]
  • 🚀100_tpch_21: 2.28s -> 1.32s [-50.36%, -34.12%]
  • ✔️100_tpch_22: 173ms -> 169ms [-7.11%, +3.18%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@krlmlr krlmlr disabled auto-merge December 16, 2024 02:51
@krlmlr krlmlr enabled auto-merge (squash) December 16, 2024 03:41
@krlmlr krlmlr merged commit f4399c2 into main Dec 16, 2024
18 of 19 checks passed
@krlmlr krlmlr deleted the f-is_ducktbl branch December 16, 2024 03:58
@github-actions GitHub Actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 44fa923 is merged into main:

  • ✔️001_tpch_01: 23.2ms -> 22.7ms [-6.54%, +2.69%]
  • ✔️001_tpch_02: 121ms -> 119ms [-2.19%, +0.41%]
  • ✔️001_tpch_03: 61.6ms -> 61.5ms [-1.82%, +1.22%]
  • ✔️001_tpch_04: 21.6ms -> 21.6ms [-0.76%, +0.93%]
  • ✔️001_tpch_05: 115ms -> 115ms [-1.45%, +1.78%]
  • ✔️001_tpch_06: 13.4ms -> 13.5ms [-1.5%, +3.07%]
  • ✔️001_tpch_07: 131ms -> 132ms [-0.72%, +2.26%]
  • ✔️001_tpch_08: 88.7ms -> 88.7ms [-0.77%, +0.72%]
  • ✔️001_tpch_09: 123ms -> 123ms [-0.97%, +0.8%]
  • ✔️001_tpch_10: 104ms -> 104ms [-0.85%, +1.43%]
  • ✔️001_tpch_11: 59.9ms -> 59.9ms [-0.91%, +0.91%]
  • ✔️001_tpch_12: 54.5ms -> 54.2ms [-2.22%, +1.22%]
  • ✔️001_tpch_13: 18.7ms -> 18.7ms [-1.27%, +1.27%]
  • ✔️001_tpch_14: 19.5ms -> 19.4ms [-1.61%, +0.63%]
  • ✔️001_tpch_15: 58.7ms -> 58.7ms [-0.79%, +0.76%]
  • ✔️001_tpch_16: 63.1ms -> 62.8ms [-2.15%, +1.21%]
  • ✔️001_tpch_17: 53.8ms -> 54.3ms [-1.5%, +3.44%]
  • ✔️001_tpch_18: 21.7ms -> 21.9ms [-1.25%, +2.73%]
  • ❗🐌001_tpch_19: 123ms -> 125ms [+0.06%, +3.69%]
  • ✔️001_tpch_20: 73ms -> 73.6ms [-0.42%, +2%]
  • ❗🐌001_tpch_21: 137ms -> 139ms [+0.46%, +2.66%]
  • ✔️001_tpch_22: 121ms -> 121ms [-1.98%, +1.76%]
  • ✔️010_tpch_01: 79.8ms -> 80.7ms [-5.63%, +8.02%]
  • ✔️010_tpch_02: 69.1ms -> 69.3ms [-1.25%, +1.82%]
  • ✔️010_tpch_03: 58.3ms -> 58.5ms [-0.55%, +1.19%]
  • ✔️010_tpch_04: 42.6ms -> 41.9ms [-4.85%, +1.54%]
  • ✔️010_tpch_05: 89.3ms -> 89ms [-1.31%, +0.74%]
  • ✔️010_tpch_06: 32.1ms -> 31.3ms [-10.53%, +5.87%]
  • ✔️010_tpch_07: 105ms -> 105ms [-1.77%, +1.56%]
  • ✔️010_tpch_08: 126ms -> 126ms [-1.49%, +0.73%]
  • ✔️010_tpch_09: 114ms -> 114ms [-1.54%, +1.19%]
  • ✔️010_tpch_10: 74.2ms -> 74.9ms [-0.15%, +2.1%]
  • ✔️010_tpch_11: 37.8ms -> 36.9ms [-5.11%, +0.33%]
  • ✔️010_tpch_12: 56.1ms -> 56.2ms [-2.13%, +2.61%]
  • ✔️010_tpch_13: 51ms -> 50.8ms [-1.56%, +0.87%]
  • ✔️010_tpch_14: 37.1ms -> 38.3ms [-4%, +10.61%]
  • ✔️010_tpch_15: 56.9ms -> 56.6ms [-3.46%, +2.65%]
  • ✔️010_tpch_16: 44.1ms -> 43.6ms [-3.95%, +1.81%]
  • ✔️010_tpch_17: 54.5ms -> 53.5ms [-5.87%, +2.44%]
  • ✔️010_tpch_18: 52.8ms -> 53.1ms [-4.45%, +5.64%]
  • 🚀010_tpch_19: 116ms -> 113ms [-3.58%, -0.99%]
  • ✔️010_tpch_20: 66.1ms -> 66.8ms [-3.03%, +5.13%]
  • ✔️010_tpch_21: 238ms -> 239ms [-2.09%, +3.1%]
  • ✔️010_tpch_22: 75.5ms -> 75ms [-2%, +0.5%]
  • ✔️100_tpch_01: 317ms -> 331ms [-16.59%, +25.21%]
  • ✔️100_tpch_02: 123ms -> 123ms [-5.36%, +5.04%]
  • ✔️100_tpch_03: 179ms -> 181ms [-1.62%, +4.85%]
  • ✔️100_tpch_04: 154ms -> 150ms [-15.86%, +10.64%]
  • ✔️100_tpch_05: 251ms -> 263ms [-7.97%, +17.92%]
  • ✔️100_tpch_06: 98.7ms -> 96ms [-8.52%, +2.94%]
  • ✔️100_tpch_07: 236ms -> 225ms [-13.05%, +3.52%]
  • ✔️100_tpch_08: 263ms -> 268ms [-1.96%, +6.32%]
  • ✔️100_tpch_09: 320ms -> 315ms [-10.04%, +7.08%]
  • ✔️100_tpch_10: 211ms -> 217ms [-6.26%, +12.35%]
  • ✔️100_tpch_11: 81.5ms -> 82.5ms [-0.16%, +2.5%]
  • ✔️100_tpch_12: 193ms -> 203ms [-6.02%, +16.56%]
  • ✔️100_tpch_13: 301ms -> 313ms [-1.45%, +9.19%]
  • ✔️100_tpch_14: 135ms -> 124ms [-16.79%, +1.26%]
  • ✔️100_tpch_15: 209ms -> 209ms [-11.53%, +11.3%]
  • ✔️100_tpch_16: 133ms -> 121ms [-23.94%, +6.41%]
  • ✔️100_tpch_17: 186ms -> 181ms [-10.03%, +4.63%]
  • ✔️100_tpch_18: 191ms -> 201ms [-5.53%, +15.68%]
  • ✔️100_tpch_19: 284ms -> 284ms [-10.55%, +10.19%]
  • ✔️100_tpch_20: 179ms -> 183ms [-7.43%, +11.48%]
  • ✔️100_tpch_21: 1.3s -> 1.32s [-4.83%, +7.73%]
  • ❗🐌100_tpch_22: 168ms -> 175ms [+0.55%, +7.99%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@krlmlr