Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add "lazy_duckplyr_df" class that requires collect() #390

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Dec 15, 2024

Closes #381.

@krlmlr krlmlr force-pushed the f-lazy branch 2 times, most recently from 035ceba to dd9f7f0 Compare December 16, 2024 02:53
@krlmlr krlmlr disabled auto-merge December 16, 2024 02:55
@krlmlr krlmlr enabled auto-merge (squash) December 16, 2024 02:56
@krlmlr krlmlr merged commit 928a95c into main Dec 16, 2024
19 checks passed
@krlmlr krlmlr deleted the f-lazy branch December 16, 2024 03:20
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if dd9f7f0 is merged into main:

  • ✔️001_tpch_01: 24.7ms -> 23.7ms [-8%, +0.56%]
  • ✔️001_tpch_02: 127ms -> 126ms [-2.02%, +0.27%]
  • 🚀001_tpch_03: 66.3ms -> 65.1ms [-3.48%, -0.21%]
  • 🚀001_tpch_04: 23.6ms -> 22.2ms [-7.13%, -4.89%]
  • ✔️001_tpch_05: 124ms -> 123ms [-2.29%, +0.7%]
  • 🚀001_tpch_06: 15.7ms -> 14.7ms [-8.55%, -3.85%]
  • 🚀001_tpch_07: 151ms -> 149ms [-2.84%, -0.29%]
  • 🚀001_tpch_08: 97.4ms -> 94.5ms [-3.7%, -2.17%]
  • 🚀001_tpch_09: 142ms -> 140ms [-2.04%, -0.58%]
  • 🚀001_tpch_10: 123ms -> 120ms [-4.45%, -0.56%]
  • ✔️001_tpch_11: 67.8ms -> 68.2ms [-0.26%, +1.48%]
  • 🚀001_tpch_12: 62.8ms -> 62ms [-2.29%, -0.27%]
  • 🚀001_tpch_13: 21.3ms -> 20.7ms [-4.58%, -1.06%]
  • 🚀001_tpch_14: 22.5ms -> 21.6ms [-5.63%, -2.43%]
  • ✔️001_tpch_15: 70.7ms -> 70.1ms [-2.47%, +0.78%]
  • ✔️001_tpch_16: 72.9ms -> 72.3ms [-2.42%, +0.74%]
  • ✔️001_tpch_17: 60.9ms -> 59.9ms [-4.69%, +1.46%]
  • 🚀001_tpch_18: 23.3ms -> 22.6ms [-4.77%, -0.87%]
  • ✔️001_tpch_19: 129ms -> 129ms [-0.48%, +1.15%]
  • 🚀001_tpch_20: 78.1ms -> 76.8ms [-2.9%, -0.53%]
  • ✔️001_tpch_21: 146ms -> 144ms [-2.85%, +0.54%]
  • ✔️001_tpch_22: 126ms -> 126ms [-1.82%, +2.08%]
  • 🚀010_tpch_01: 84ms -> 79.4ms [-10.97%, -0.06%]
  • ✔️010_tpch_02: 72.5ms -> 71.6ms [-3.37%, +0.77%]
  • 🚀010_tpch_03: 67.1ms -> 62.1ms [-9.39%, -5.59%]
  • 🚀010_tpch_04: 47.3ms -> 43.7ms [-10.17%, -4.85%]
  • 🚀010_tpch_05: 96.2ms -> 91.1ms [-7.45%, -3.12%]
  • 🚀010_tpch_06: 37.6ms -> 32.1ms [-22.93%, -6.07%]
  • 🚀010_tpch_07: 110ms -> 107ms [-3.98%, -1.06%]
  • 🚀010_tpch_08: 133ms -> 128ms [-5.19%, -3.24%]
  • 🚀010_tpch_09: 122ms -> 117ms [-6.33%, -2.01%]
  • 🚀010_tpch_10: 80ms -> 76.7ms [-6.21%, -2.13%]
  • ✔️010_tpch_11: 38.9ms -> 38.9ms [-3.98%, +4.41%]
  • 🚀010_tpch_12: 61.1ms -> 56.9ms [-8.65%, -4.94%]
  • ✔️010_tpch_13: 56.1ms -> 52ms [-17.19%, +2.49%]
  • 🚀010_tpch_14: 41.8ms -> 38.7ms [-8.92%, -6.12%]
  • ✔️010_tpch_15: 58.5ms -> 56.3ms [-9.7%, +2.26%]
  • ✔️010_tpch_16: 45.1ms -> 45.1ms [-2.2%, +2.32%]
  • 🚀010_tpch_17: 57.8ms -> 54.9ms [-9.54%, -0.33%]
  • ✔️010_tpch_18: 56.1ms -> 53.7ms [-9.47%, +0.94%]
  • 🚀010_tpch_19: 122ms -> 117ms [-7.21%, -0.62%]
  • 🚀010_tpch_20: 71ms -> 67ms [-6.85%, -4.33%]
  • 🚀010_tpch_21: 386ms -> 239ms [-39.76%, -36.23%]
  • ✔️010_tpch_22: 77.9ms -> 76.8ms [-3.47%, +0.63%]
  • 🚀100_tpch_01: 1.23s -> 326ms [-75.61%, -71.33%]
  • ✔️100_tpch_02: 128ms -> 126ms [-6.63%, +3.28%]
  • 🚀100_tpch_03: 1.13s -> 185ms [-87.27%, -79.92%]
  • 🚀100_tpch_04: 1.06s -> 157ms [-87.79%, -82.73%]
  • 🚀100_tpch_05: 1.19s -> 260ms [-81.61%, -74.88%]
  • 🚀100_tpch_06: 1.02s -> 102ms [-90.84%, -89.09%]
  • 🚀100_tpch_07: 1.15s -> 231ms [-84.22%, -75.6%]
  • 🚀100_tpch_08: 1.2s -> 258ms [-79.95%, -76.94%]
  • 🚀100_tpch_09: 1.27s -> 329ms [-78.94%, -69.1%]
  • 🚀100_tpch_10: 1.11s -> 221ms [-82.29%, -78.05%]
  • ✔️100_tpch_11: 92.3ms -> 89.1ms [-34.25%, +27.31%]
  • 🚀100_tpch_12: 1.11s -> 196ms [-83.71%, -80.91%]
  • ✔️100_tpch_13: 312ms -> 311ms [-6.58%, +5.5%]
  • 🚀100_tpch_14: 1.03s -> 131ms [-89.32%, -85.25%]
  • 🚀100_tpch_15: 1.13s -> 212ms [-82.53%, -79.86%]
  • ✔️100_tpch_16: 124ms -> 126ms [-5.26%, +7.63%]
  • 🚀100_tpch_17: 1.11s -> 174ms [-89.39%, -79.29%]
  • 🚀100_tpch_18: 1.13s -> 189ms [-85.56%, -80.91%]
  • 🚀100_tpch_19: 1.21s -> 282ms [-79.58%, -73.59%]
  • 🚀100_tpch_20: 1.1s -> 179ms [-85.25%, -82.38%]
  • 🚀100_tpch_21: 2.26s -> 1.31s [-45.7%, -38.16%]
  • ✔️100_tpch_22: 175ms -> 172ms [-12.7%, +9.38%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add subclass that disables materialization by default
1 participant