Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New as_ducktbl(), replaces as_duckplyr_tibble() and as_duckplyr_df() #383

Merged
merged 3 commits into from
Dec 15, 2024

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Dec 15, 2024

No description provided.

@krlmlr krlmlr enabled auto-merge (squash) December 15, 2024 15:06
@krlmlr krlmlr merged commit 21a8f68 into main Dec 15, 2024
19 checks passed
@krlmlr krlmlr deleted the f-as_ducktbl branch December 15, 2024 15:39
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if c158648 is merged into main:

  • ✔️001_tpch_01: 24.9ms -> 24.2ms [-6.41%, +0.75%]
  • ✔️001_tpch_02: 127ms -> 126ms [-0.95%, +0.8%]
  • ✔️001_tpch_03: 66.3ms -> 66ms [-2.05%, +1.17%]
  • ✔️001_tpch_04: 23.6ms -> 23.5ms [-2.6%, +1.5%]
  • ✔️001_tpch_05: 120ms -> 121ms [-0.6%, +1.24%]
  • ✔️001_tpch_06: 14.7ms -> 14.5ms [-3.56%, +0.56%]
  • ✔️001_tpch_07: 139ms -> 140ms [-0.47%, +1.79%]
  • ✔️001_tpch_08: 94.2ms -> 94.1ms [-1.1%, +0.78%]
  • ✔️001_tpch_09: 131ms -> 131ms [-1.07%, +1.08%]
  • ❗🐌001_tpch_10: 111ms -> 141ms [+25.03%, +27.93%]
  • ✔️001_tpch_11: 63.8ms -> 63.6ms [-1.94%, +1.23%]
  • ✔️001_tpch_12: 59.5ms -> 59.8ms [-1.6%, +2.42%]
  • ✔️001_tpch_13: 20ms -> 20.1ms [-2.55%, +3.43%]
  • ✔️001_tpch_14: 21.1ms -> 21.2ms [-0.77%, +2.27%]
  • ✔️001_tpch_15: 63.5ms -> 63.8ms [-1.36%, +2.26%]
  • ✔️001_tpch_16: 65.5ms -> 65.6ms [-1.32%, +1.52%]
  • ✔️001_tpch_17: 58ms -> 57.8ms [-1.88%, +0.96%]
  • ✔️001_tpch_18: 23.8ms -> 23.4ms [-4.07%, +0.84%]
  • ❗🐌001_tpch_19: 128ms -> 129ms [+0.06%, +1.85%]
  • ✔️001_tpch_20: 79.1ms -> 78.8ms [-1.77%, +0.92%]
  • ✔️001_tpch_21: 145ms -> 146ms [-0.6%, +2.2%]
  • 🚀001_tpch_22: 127ms -> 125ms [-2.03%, -0.03%]
  • ✔️010_tpch_01: 83.7ms -> 83.3ms [-5.7%, +4.53%]
  • ✔️010_tpch_02: 72.1ms -> 71.6ms [-1.84%, +0.53%]
  • ✔️010_tpch_03: 64.9ms -> 65.4ms [-1.22%, +2.57%]
  • ✔️010_tpch_04: 46.4ms -> 46.4ms [-0.97%, +0.66%]
  • ✔️010_tpch_05: 95.7ms -> 96.1ms [-1.23%, +1.89%]
  • ✔️010_tpch_06: 37.5ms -> 36.3ms [-11.51%, +4.89%]
  • ✔️010_tpch_07: 113ms -> 112ms [-3.3%, +2.39%]
  • ✔️010_tpch_08: 133ms -> 135ms [-0.81%, +3.41%]
  • ✔️010_tpch_09: 121ms -> 122ms [-1.64%, +2.78%]
  • ✔️010_tpch_10: 80.6ms -> 79.8ms [-2.73%, +0.86%]
  • ✔️010_tpch_11: 38.9ms -> 38.3ms [-6.24%, +3.04%]
  • ✔️010_tpch_12: 61ms -> 61.1ms [-1.73%, +1.99%]
  • ✔️010_tpch_13: 55.2ms -> 56ms [-9.99%, +12.82%]
  • ✔️010_tpch_14: 40.8ms -> 41.7ms [-1.44%, +5.81%]
  • ✔️010_tpch_15: 58.3ms -> 57.9ms [-8.41%, +6.75%]
  • ✔️010_tpch_16: 45.5ms -> 45.6ms [-3.13%, +3.8%]
  • ✔️010_tpch_17: 58.6ms -> 58.2ms [-4.37%, +3.09%]
  • ✔️010_tpch_18: 55.7ms -> 57.8ms [-1.97%, +9.39%]
  • ✔️010_tpch_19: 120ms -> 119ms [-2.38%, +0.87%]
  • ✔️010_tpch_20: 71.4ms -> 72.2ms [-1.96%, +4.29%]
  • ✔️010_tpch_21: 380ms -> 378ms [-1.9%, +0.57%]
  • ✔️010_tpch_22: 78.2ms -> 79.7ms [-2.11%, +5.96%]
  • ✔️100_tpch_01: 1.17s -> 1.17s [-1.89%, +2.68%]
  • ✔️100_tpch_02: 132ms -> 126ms [-19.71%, +10.76%]
  • ❗🐌100_tpch_03: 1.05s -> 1.06s [+0.12%, +1.8%]
  • ✔️100_tpch_04: 1.05s -> 1.02s [-5.69%, +0.15%]
  • ✔️100_tpch_05: 1.15s -> 1.16s [-5.42%, +7.65%]
  • ✔️100_tpch_06: 996ms -> 972ms [-6.94%, +2.23%]
  • ✔️100_tpch_07: 1.11s -> 1.11s [-1.94%, +1.48%]
  • ✔️100_tpch_08: 1.14s -> 1.15s [-4.39%, +5.86%]
  • ✔️100_tpch_09: 1.21s -> 1.24s [-1.69%, +5.37%]
  • ✔️100_tpch_10: 1.09s -> 1.08s [-3.21%, +1.12%]
  • ✔️100_tpch_11: 97ms -> 83.5ms [-40.3%, +12.51%]
  • ✔️100_tpch_12: 1.07s -> 1.07s [-1.74%, +3.31%]
  • ✔️100_tpch_13: 343ms -> 332ms [-12.94%, +6.61%]
  • ✔️100_tpch_14: 1s -> 1s [-1.3%, +1.07%]
  • ✔️100_tpch_15: 1.08s -> 1.08s [-1.49%, +2.31%]
  • ✔️100_tpch_16: 128ms -> 122ms [-12.34%, +2.81%]
  • ✔️100_tpch_17: 1.05s -> 1.06s [-2.16%, +4.59%]
  • ✔️100_tpch_18: 1.09s -> 1.09s [-2.78%, +4.13%]
  • ✔️100_tpch_19: 1.17s -> 1.18s [-3.71%, +5.35%]
  • ✔️100_tpch_20: 1.06s -> 1.07s [-2.22%, +4.74%]
  • ✔️100_tpch_21: 2.24s -> 2.18s [-9.49%, +3.87%]
  • ✔️100_tpch_22: 172ms -> 176ms [-3.5%, +7.77%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant