Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Printing a duckplyr frame no longer materializes #378

Merged
merged 2 commits into from
Dec 15, 2024
Merged

perf: Printing a duckplyr frame no longer materializes #378

merged 2 commits into from
Dec 15, 2024

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Dec 14, 2024 •
edited
Loading

Closes #255.

@krlmlr krlmlr changed the title f 255 print Overwrite + restore Dec 14, 2024
@krlmlr krlmlr enabled auto-merge (squash) December 14, 2024 16:07
@krlmlr krlmlr disabled auto-merge December 14, 2024 16:07
@krlmlr krlmlr changed the title Overwrite + restore chore: Printing a duckplyr frame no longer materializes Dec 14, 2024
@krlmlr krlmlr enabled auto-merge (squash) December 14, 2024 16:08
@krlmlr krlmlr disabled auto-merge December 14, 2024 16:08
@krlmlr krlmlr enabled auto-merge (squash) December 14, 2024 16:11
@krlmlr krlmlr requested a review from hadley December 14, 2024 16:12
@github-actions GitHub Actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 6d0ade7 is merged into main:

  • ✔️001_tpch_01: 24.6ms -> 25.1ms [-1.78%, +6.07%]
  • ✔️001_tpch_02: 132ms -> 132ms [-2.22%, +1.35%]
  • ✔️001_tpch_03: 69.6ms -> 68.8ms [-2.99%, +0.93%]
  • ✔️001_tpch_04: 24.5ms -> 24.5ms [-3.45%, +3.76%]
  • ✔️001_tpch_05: 126ms -> 127ms [-0.88%, +2.33%]
  • 🚀001_tpch_06: 15.5ms -> 15ms [-5.8%, -0.52%]
  • ✔️001_tpch_07: 143ms -> 143ms [-0.71%, +1.71%]
  • ❗🐌001_tpch_08: 94.3ms -> 96.4ms [+0.51%, +4.04%]
  • ✔️001_tpch_09: 135ms -> 135ms [-0.9%, +1.6%]
  • ✔️001_tpch_10: 116ms -> 115ms [-2.31%, +0.59%]
  • ✔️001_tpch_11: 65.4ms -> 65.7ms [-1.22%, +1.98%]
  • ✔️001_tpch_12: 61.2ms -> 61.3ms [-1.65%, +1.95%]
  • ✔️001_tpch_13: 20.4ms -> 20.4ms [-1.96%, +2.05%]
  • ✔️001_tpch_14: 21.9ms -> 22ms [-2.59%, +4.33%]
  • ✔️001_tpch_15: 66.7ms -> 67.1ms [-2.02%, +3.29%]
  • ✔️001_tpch_16: 68ms -> 68.2ms [-2.46%, +3.05%]
  • ✔️001_tpch_17: 60.7ms -> 59.9ms [-3.69%, +0.97%]
  • ❗🐌001_tpch_18: 24.2ms -> 24.8ms [+0.13%, +4.53%]
  • ✔️001_tpch_19: 132ms -> 132ms [-1.58%, +0.66%]
  • ❗🐌001_tpch_20: 79.8ms -> 81.2ms [+0.07%, +3.43%]
  • ✔️001_tpch_21: 145ms -> 146ms [-0.33%, +1.81%]
  • ✔️001_tpch_22: 129ms -> 128ms [-2.11%, +0.38%]
  • ✔️010_tpch_01: 85.4ms -> 83ms [-6.89%, +1.17%]
  • ✔️010_tpch_02: 74.1ms -> 73.4ms [-3.76%, +1.75%]
  • ✔️010_tpch_03: 65.5ms -> 66.1ms [-1.26%, +2.97%]
  • ✔️010_tpch_04: 47ms -> 48ms [-0.36%, +4.45%]
  • ✔️010_tpch_05: 96.6ms -> 97ms [-1.33%, +2.19%]
  • ✔️010_tpch_06: 37.2ms -> 35.7ms [-8.8%, +0.76%]
  • ✔️010_tpch_07: 116ms -> 113ms [-5.65%, +0.57%]
  • ✔️010_tpch_08: 136ms -> 134ms [-2.97%, +0.68%]
  • ✔️010_tpch_09: 123ms -> 124ms [-1.61%, +4.66%]
  • ✔️010_tpch_10: 80.3ms -> 81ms [-1.29%, +3%]
  • ✔️010_tpch_11: 39.2ms -> 39.3ms [-3.19%, +3.4%]
  • ✔️010_tpch_12: 63ms -> 60.8ms [-8.26%, +1.37%]
  • ✔️010_tpch_13: 53.4ms -> 55.7ms [-1.19%, +9.69%]
  • ✔️010_tpch_14: 42.1ms -> 41.5ms [-4.52%, +1.51%]
  • ✔️010_tpch_15: 57.6ms -> 60.6ms [-0.78%, +11.09%]
  • ✔️010_tpch_16: 46.1ms -> 46ms [-2.95%, +2.49%]
  • ✔️010_tpch_17: 57.9ms -> 58.3ms [-1.5%, +2.67%]
  • ✔️010_tpch_18: 58.8ms -> 57.7ms [-9.43%, +5.66%]
  • ✔️010_tpch_19: 122ms -> 121ms [-1.68%, +1.31%]
  • ✔️010_tpch_20: 74.2ms -> 72.5ms [-5.64%, +0.93%]
  • ✔️010_tpch_21: 392ms -> 394ms [-1.83%, +2.85%]
  • ✔️010_tpch_22: 79.9ms -> 79ms [-3.82%, +1.7%]
  • ✔️100_tpch_01: 1.2s -> 1.18s [-4.61%, +1.56%]
  • ✔️100_tpch_02: 128ms -> 129ms [-1.55%, +2.57%]
  • ✔️100_tpch_03: 1.06s -> 1.07s [-0.47%, +2.32%]
  • ✔️100_tpch_04: 1.05s -> 1.04s [-2.02%, +0.55%]
  • ✔️100_tpch_05: 1.19s -> 1.17s [-3.68%, +0.5%]
  • ✔️100_tpch_06: 1.01s -> 996ms [-4.09%, +1.34%]
  • ✔️100_tpch_07: 1.13s -> 1.15s [-3.9%, +6.22%]
  • ✔️100_tpch_08: 1.15s -> 1.17s [-1.7%, +4.35%]
  • ✔️100_tpch_09: 1.25s -> 1.28s [-4.72%, +9.97%]
  • ✔️100_tpch_10: 1.09s -> 1.11s [-0.94%, +3.46%]
  • ✔️100_tpch_11: 82.7ms -> 82.2ms [-3.67%, +2.46%]
  • ✔️100_tpch_12: 1.1s -> 1.08s [-4.68%, +2.3%]
  • ✔️100_tpch_13: 334ms -> 323ms [-12.13%, +5.47%]
  • ✔️100_tpch_14: 1.02s -> 1.02s [-3.05%, +2.26%]
  • ✔️100_tpch_15: 1.11s -> 1.11s [-2.99%, +2.66%]
  • ✔️100_tpch_16: 123ms -> 125ms [-3.28%, +6.14%]
  • ✔️100_tpch_17: 1.07s -> 1.09s [-1.2%, +4.39%]
  • ✔️100_tpch_18: 1.11s -> 1.13s [-3.15%, +6.26%]
  • ✔️100_tpch_19: 1.19s -> 1.19s [-6.53%, +5.67%]
  • 🚀100_tpch_20: 1.09s -> 1.07s [-3.03%, -0.4%]
  • ✔️100_tpch_21: 2.23s -> 2.25s [-1.35%, +3.48%]
  • ✔️100_tpch_22: 171ms -> 173ms [-0.58%, +2.62%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@krlmlr krlmlr changed the title chore: Printing a duckplyr frame no longer materializes perf: Printing a duckplyr frame no longer materializes Dec 15, 2024
@krlmlr krlmlr merged commit 0863e7c into main Dec 15, 2024
19 checks passed
@krlmlr krlmlr deleted the f-255-print branch December 15, 2024 10:44
@github-actions GitHub Actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 0d01af1 is merged into main:

  • ✔️001_tpch_01: 23.5ms -> 23.9ms [-2.65%, +5.6%]
  • ✔️001_tpch_02: 120ms -> 119ms [-0.87%, +0.36%]
  • ✔️001_tpch_03: 61.9ms -> 62.2ms [-0.18%, +1.33%]
  • ✔️001_tpch_04: 22.7ms -> 22.6ms [-2.1%, +1.34%]
  • ✔️001_tpch_05: 115ms -> 114ms [-2%, +0.3%]
  • ✔️001_tpch_06: 14.3ms -> 14ms [-4.58%, +0.58%]
  • ✔️001_tpch_07: 132ms -> 131ms [-0.87%, +0.4%]
  • ✔️001_tpch_08: 90.8ms -> 91.2ms [-0.05%, +1.05%]
  • ✔️001_tpch_09: 125ms -> 125ms [-0.83%, +1.05%]
  • ✔️001_tpch_10: 105ms -> 104ms [-1.7%, +0.53%]
  • ✔️001_tpch_11: 59.3ms -> 59.1ms [-0.77%, +0.27%]
  • ✔️001_tpch_12: 54.7ms -> 54.9ms [-0.32%, +0.99%]
  • ✔️001_tpch_13: 18.9ms -> 19ms [-0.94%, +1.39%]
  • ❗🐌001_tpch_14: 20.3ms -> 20.5ms [+0.04%, +1.77%]
  • ✔️001_tpch_15: 59.2ms -> 59.5ms [-0.84%, +1.71%]
  • ✔️001_tpch_16: 61.5ms -> 61.4ms [-0.72%, +0.39%]
  • ✔️001_tpch_17: 53.1ms -> 53.2ms [-0.48%, +0.95%]
  • ✔️001_tpch_18: 22.6ms -> 22.5ms [-2.15%, +1.24%]
  • ✔️001_tpch_19: 122ms -> 122ms [-0.74%, +0.63%]
  • ✔️001_tpch_20: 72.9ms -> 73ms [-0.41%, +0.57%]
  • ✔️001_tpch_21: 138ms -> 138ms [-0.86%, +1.47%]
  • ✔️001_tpch_22: 119ms -> 119ms [-1.13%, +0.89%]
  • ✔️010_tpch_01: 82.3ms -> 83.7ms [-2.93%, +6.45%]
  • ✔️010_tpch_02: 70.8ms -> 71.7ms [-3.95%, +6.57%]
  • ✔️010_tpch_03: 64.5ms -> 62.8ms [-5.95%, +0.59%]
  • ✔️010_tpch_04: 46.3ms -> 45.1ms [-5.74%, +0.36%]
  • ✔️010_tpch_05: 96.6ms -> 93ms [-7.82%, +0.25%]
  • ✔️010_tpch_06: 34.9ms -> 36.3ms [-7.35%, +15.06%]
  • ✔️010_tpch_07: 109ms -> 109ms [-0.48%, +0.71%]
  • ✔️010_tpch_08: 130ms -> 130ms [-0.94%, +1.13%]
  • ✔️010_tpch_09: 118ms -> 119ms [-1.14%, +2.53%]
  • ✔️010_tpch_10: 78.9ms -> 78ms [-3.3%, +1.11%]
  • ✔️010_tpch_11: 37.6ms -> 37.1ms [-5.78%, +3.16%]
  • ✔️010_tpch_12: 60.1ms -> 60.5ms [-1.66%, +3.07%]
  • ✔️010_tpch_13: 53.6ms -> 51.4ms [-10.91%, +2.79%]
  • ✔️010_tpch_14: 41.1ms -> 39.8ms [-7.29%, +1.11%]
  • ✔️010_tpch_15: 55.4ms -> 56.7ms [-6.08%, +10.79%]
  • ✔️010_tpch_16: 43.5ms -> 43.7ms [-1.65%, +2.56%]
  • ✔️010_tpch_17: 56.3ms -> 57ms [-4.2%, +6.49%]
  • ✔️010_tpch_18: 56ms -> 55.5ms [-6.83%, +4.9%]
  • ✔️010_tpch_19: 117ms -> 118ms [-0.42%, +2.1%]
  • ✔️010_tpch_20: 69.9ms -> 68.9ms [-4.05%, +1.07%]
  • ✔️010_tpch_21: 373ms -> 372ms [-2.3%, +1.39%]
  • ✔️010_tpch_22: 76.3ms -> 76.2ms [-2.35%, +2.07%]
  • 🚀100_tpch_01: 1.19s -> 1.15s [-5.51%, -1.19%]
  • ✔️100_tpch_02: 125ms -> 124ms [-2.45%, +1.93%]
  • ✔️100_tpch_03: 1.05s -> 1.06s [-1.27%, +2.98%]
  • 🚀100_tpch_04: 1.01s -> 1s [-0.96%, -0.17%]
  • ✔️100_tpch_05: 1.13s -> 1.11s [-3.74%, +0.87%]
  • ✔️100_tpch_06: 965ms -> 967ms [-1.11%, +1.49%]
  • ✔️100_tpch_07: 1.08s -> 1.08s [-1.82%, +2.39%]
  • ✔️100_tpch_08: 1.11s -> 1.11s [-2.11%, +2.34%]
  • ✔️100_tpch_09: 1.21s -> 1.21s [-1.93%, +2.13%]
  • ✔️100_tpch_10: 1.06s -> 1.06s [-2.78%, +2.23%]
  • ✔️100_tpch_11: 85.4ms -> 82.3ms [-10.3%, +3.03%]
  • ✔️100_tpch_12: 1.05s -> 1.05s [-2.09%, +3.19%]
  • ✔️100_tpch_13: 308ms -> 301ms [-7.25%, +2.41%]
  • ✔️100_tpch_14: 980ms -> 982ms [-0.41%, +0.77%]
  • ✔️100_tpch_15: 1.08s -> 1.07s [-2.96%, +1.79%]
  • ✔️100_tpch_16: 126ms -> 126ms [-7.9%, +7.8%]
  • ✔️100_tpch_17: 1.03s -> 1.04s [-1.34%, +2.82%]
  • ✔️100_tpch_18: 1.07s -> 1.05s [-2.82%, +0.37%]
  • ❗🐌100_tpch_19: 1.13s -> 1.15s [+0.54%, +2.96%]
  • ✔️100_tpch_20: 1.04s -> 1.03s [-3.35%, +1.95%]
  • ✔️100_tpch_21: 2.21s -> 2.17s [-5.87%, +1.86%]
  • ✔️100_tpch_22: 175ms -> 175ms [-5.74%, +6.42%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadley hadley Awaiting requested review from hadley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add better print() method
1 participant
@krlmlr