Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve as_duckplyr_df() error message for invalid .data #339

Merged
merged 3 commits into from
Dec 14, 2024
Merged

feat: improve as_duckplyr_df() error message for invalid .data #339

merged 3 commits into from
Dec 14, 2024

Conversation

maelle
Copy link
Collaborator

@maelle maelle commented Nov 14, 2024 •
edited by krlmlr
Loading

For #127

Not docs but this was a low-hanging fruit to warm up. 😉

@maelle maelle requested a review from krlmlr November 14, 2024 13:44
@github-actions GitHub Actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if cf2b613 is merged into main:

  • ✔️001_tpch_01: 24.6ms -> 24.5ms [-4.31%, +3.47%]
  • ✔️001_tpch_02: 128ms -> 128ms [-1.34%, +0.92%]
  • ✔️001_tpch_03: 68.4ms -> 68.5ms [-1.7%, +2.16%]
  • ✔️001_tpch_04: 24.8ms -> 24.5ms [-2.85%, +0.5%]
  • ✔️001_tpch_05: 123ms -> 123ms [-1.91%, +1.24%]
  • ✔️001_tpch_06: 15.4ms -> 15.4ms [-1.92%, +1.98%]
  • ✔️001_tpch_07: 141ms -> 142ms [-0.54%, +1.44%]
  • ✔️001_tpch_08: 161ms -> 160ms [-1.39%, +0.5%]
  • ✔️001_tpch_09: 131ms -> 131ms [-1.37%, +0.52%]
  • ✔️001_tpch_10: 77.2ms -> 77.7ms [-0.81%, +2.15%]
  • ✔️001_tpch_11: 64.4ms -> 64.3ms [-2.26%, +1.98%]
  • ✔️001_tpch_12: 29.2ms -> 29.3ms [-1.07%, +1.99%]
  • ✔️001_tpch_13: 20.6ms -> 20.1ms [-4.62%, +0.45%]
  • ✔️001_tpch_14: 21.7ms -> 22ms [-0.8%, +3.33%]
  • ✔️001_tpch_15: 64.7ms -> 64.3ms [-2.53%, +1.13%]
  • ✔️001_tpch_16: 66.2ms -> 65.9ms [-1.65%, +0.84%]
  • ✔️001_tpch_17: 28.3ms -> 28.3ms [-3.01%, +2.96%]
  • ✔️001_tpch_18: 23.6ms -> 23.7ms [-1.67%, +2.02%]
  • ✔️001_tpch_19: 133ms -> 132ms [-1.9%, +0.97%]
  • ✔️001_tpch_20: 80.1ms -> 80.1ms [-1.6%, +1.41%]
  • ✔️001_tpch_21: 177ms -> 176ms [-1.92%, +0.4%]
  • ✔️001_tpch_22: 128ms -> 128ms [-1.35%, +1.14%]
  • ✔️010_tpch_01: 84.9ms -> 81.2ms [-8.82%, +0.28%]
  • ✔️010_tpch_02: 74.1ms -> 73.8ms [-4.7%, +3.91%]
  • ✔️010_tpch_03: 66.6ms -> 67.5ms [-0.23%, +2.91%]
  • ✔️010_tpch_04: 49.6ms -> 49.9ms [-1.29%, +2.31%]
  • ✔️010_tpch_05: 95.3ms -> 95.4ms [-1.1%, +1.25%]
  • ✔️010_tpch_06: 37ms -> 36.7ms [-8.4%, +6.48%]
  • ✔️010_tpch_07: 116ms -> 115ms [-3.28%, +0.24%]
  • ✔️010_tpch_08: 136ms -> 135ms [-2.43%, +0.55%]
  • ✔️010_tpch_09: 120ms -> 119ms [-2.2%, +1.33%]
  • ✔️010_tpch_10: 85.1ms -> 84.6ms [-2.82%, +1.65%]
  • ✔️010_tpch_11: 39.4ms -> 38.8ms [-4.16%, +1%]
  • ✔️010_tpch_12: 64.1ms -> 63.6ms [-4.21%, +2.69%]
  • ✔️010_tpch_13: 53.7ms -> 53.3ms [-3.18%, +1.69%]
  • ✔️010_tpch_14: 43.5ms -> 43.3ms [-8.27%, +7.58%]
  • ✔️010_tpch_15: 60.5ms -> 59.1ms [-7.95%, +3.12%]
  • ✔️010_tpch_16: 45.5ms -> 45.4ms [-1.97%, +1.49%]
  • ❗🐌010_tpch_17: 55.5ms -> 56.5ms [+0.48%, +3.2%]
  • ✔️010_tpch_18: 53.8ms -> 52.8ms [-8.1%, +4.52%]
  • ✔️010_tpch_19: 125ms -> 125ms [-1.94%, +1.86%]
  • ✔️010_tpch_20: 74.5ms -> 74.1ms [-4.97%, +3.83%]
  • ✔️010_tpch_21: 413ms -> 414ms [-1.22%, +1.62%]
  • ✔️010_tpch_22: 78.7ms -> 77.9ms [-3%, +0.95%]
  • ✔️100_tpch_01: 1.21s -> 1.19s [-7.47%, +5.69%]
  • ✔️100_tpch_02: 128ms -> 120ms [-12.16%, +0.49%]
  • ✔️100_tpch_03: 1.07s -> 1.09s [-1.14%, +5.84%]
  • ✔️100_tpch_04: 1.06s -> 1.05s [-2.75%, +2.41%]
  • ✔️100_tpch_05: 1.16s -> 1.15s [-3.55%, +2.6%]
  • ✔️100_tpch_06: 990ms -> 990ms [-1.26%, +1.11%]
  • 🚀100_tpch_07: 1.12s -> 1.11s [-1.69%, -0.34%]
  • 🚀100_tpch_08: 1.16s -> 1.14s [-2.63%, -0.59%]
  • ✔️100_tpch_09: 1.22s -> 1.24s [-1.1%, +4.37%]
  • ✔️100_tpch_10: 1.1s -> 1.1s [-1.87%, +1.86%]
  • ✔️100_tpch_11: 84.2ms -> 85.3ms [-9.54%, +12.02%]
  • ✔️100_tpch_12: 1.08s -> 1.09s [-3%, +4.39%]
  • ✔️100_tpch_13: 323ms -> 312ms [-8.52%, +1.63%]
  • ✔️100_tpch_14: 1.01s -> 1.01s [-2.45%, +3.47%]
  • ✔️100_tpch_15: 1.11s -> 1.1s [-3.52%, +3.02%]
  • ✔️100_tpch_16: 130ms -> 133ms [-17.99%, +23.5%]
  • ✔️100_tpch_17: 1.05s -> 1.04s [-2.94%, +0.08%]
  • ✔️100_tpch_18: 1.08s -> 1.08s [-1.88%, +1.26%]
  • ✔️100_tpch_19: 1.19s -> 1.17s [-6.11%, +3.08%]
  • ✔️100_tpch_20: 1.08s -> 1.07s [-4.36%, +2.57%]
  • ✔️100_tpch_21: 2.2s -> 2.25s [-1.07%, +5.61%]
  • ✔️100_tpch_22: 177ms -> 169ms [-10.33%, +1.75%]

Further explanation regarding interpretation and methodology can be found in the documentation.

krlmlr
krlmlr reviewed Nov 15, 2024
View reviewed changes
Copy link
Member

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm just envisioning someone removing that seemingly extra space in a future revision.

maelle
maelle commented Nov 15, 2024
View reviewed changes
tests/testthat/test-as_duckplyr_df.R Outdated

by_cyl <- dplyr::group_by(mtcars, cyl)
expect_snapshot(error = TRUE, {
as_duckplyr_df(by_cyl)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe in this case the error is misleading, would you convert a grouped data.frame by converting it thus losing its grouping

@github-actions GitHub Actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if e718a07 is merged into main:

  • ✔️001_tpch_01: 24.5ms -> 25.3ms [-0.9%, +7.47%]
  • 🚀001_tpch_02: 133ms -> 130ms [-3.18%, -0.56%]
  • ✔️001_tpch_03: 71.7ms -> 72.7ms [-1.03%, +3.89%]
  • ❗🐌001_tpch_04: 24.7ms -> 25.5ms [+0.15%, +6.21%]
  • ✔️001_tpch_05: 122ms -> 122ms [-1.37%, +1.37%]
  • ✔️001_tpch_06: 15.4ms -> 15.7ms [-1.26%, +5.15%]
  • ✔️001_tpch_07: 149ms -> 148ms [-2.73%, +1.48%]
  • ✔️001_tpch_08: 167ms -> 165ms [-2.82%, +0.86%]
  • ✔️001_tpch_09: 139ms -> 138ms [-2.83%, +0.72%]
  • ✔️001_tpch_10: 79.4ms -> 79.1ms [-3.09%, +2.37%]
  • ✔️001_tpch_11: 66.3ms -> 66.4ms [-3.33%, +3.71%]
  • ✔️001_tpch_12: 29.6ms -> 29.8ms [-1.46%, +2.74%]
  • ✔️001_tpch_13: 21.1ms -> 21.1ms [-2.17%, +2.18%]
  • ✔️001_tpch_14: 22ms -> 21.9ms [-2.89%, +1.43%]
  • ❗🐌001_tpch_15: 64.3ms -> 65.4ms [+0.02%, +3.37%]
  • ✔️001_tpch_16: 66.4ms -> 67.4ms [-0.76%, +3.79%]
  • ✔️001_tpch_17: 28ms -> 27.7ms [-3.22%, +1.07%]
  • ✔️001_tpch_18: 23.5ms -> 24ms [-0.91%, +4.48%]
  • ✔️001_tpch_19: 130ms -> 131ms [-0.43%, +1.71%]
  • ✔️001_tpch_20: 79.4ms -> 79.4ms [-1.55%, +1.79%]
  • ✔️001_tpch_21: 176ms -> 175ms [-1.81%, +1.38%]
  • ✔️001_tpch_22: 125ms -> 125ms [-1.34%, +0.75%]
  • ✔️010_tpch_01: 82.5ms -> 82.8ms [-3.17%, +3.86%]
  • ✔️010_tpch_02: 70.9ms -> 71.7ms [-1.15%, +3.3%]
  • ❗🐌010_tpch_03: 66.5ms -> 67.6ms [+0.35%, +2.81%]
  • ✔️010_tpch_04: 49.3ms -> 49.5ms [-1.37%, +1.9%]
  • ✔️010_tpch_05: 95.4ms -> 95.8ms [-1.04%, +1.82%]
  • ✔️010_tpch_06: 35.8ms -> 36.1ms [-5.21%, +6.88%]
  • ✔️010_tpch_07: 119ms -> 119ms [-1.66%, +2.67%]
  • ✔️010_tpch_08: 140ms -> 143ms [-0.96%, +4.69%]
  • ✔️010_tpch_09: 124ms -> 122ms [-4.62%, +1.43%]
  • ✔️010_tpch_10: 86.4ms -> 86.5ms [-4.71%, +4.88%]
  • ✔️010_tpch_11: 39ms -> 38.2ms [-5.54%, +1.44%]
  • ✔️010_tpch_12: 64.2ms -> 66.4ms [-3.81%, +10.72%]
  • ✔️010_tpch_13: 52.8ms -> 52.9ms [-1.69%, +2.01%]
  • ✔️010_tpch_14: 43.4ms -> 44ms [-1.92%, +5.02%]
  • ✔️010_tpch_15: 58.4ms -> 61.6ms [-2.42%, +13.46%]
  • ✔️010_tpch_16: 46.9ms -> 47.1ms [-2%, +2.72%]
  • ✔️010_tpch_17: 58.5ms -> 58.2ms [-2.59%, +1.88%]
  • ✔️010_tpch_18: 56.1ms -> 57.2ms [-4.85%, +8.74%]
  • ✔️010_tpch_19: 124ms -> 124ms [-1.32%, +2.14%]
  • ✔️010_tpch_20: 75.1ms -> 74.6ms [-2.68%, +1.26%]
  • ✔️010_tpch_21: 431ms -> 429ms [-2.4%, +1.54%]
  • ✔️010_tpch_22: 79ms -> 78.3ms [-3.57%, +1.73%]
  • ✔️100_tpch_01: 1.19s -> 1.23s [-1.09%, +7.44%]
  • ✔️100_tpch_02: 123ms -> 126ms [-9.65%, +15.04%]
  • ✔️100_tpch_03: 1.1s -> 1.08s [-4.71%, +0.34%]
  • ✔️100_tpch_04: 1.12s -> 1.06s [-13.86%, +3.16%]
  • ✔️100_tpch_05: 1.18s -> 1.18s [-1.52%, +1.11%]
  • ✔️100_tpch_06: 1.01s -> 1s [-2.61%, +0.97%]
  • ✔️100_tpch_07: 1.16s -> 1.15s [-6.36%, +3.46%]
  • ✔️100_tpch_08: 1.16s -> 1.15s [-3.61%, +2.61%]
  • ✔️100_tpch_09: 1.26s -> 1.22s [-7.55%, +1.72%]
  • ✔️100_tpch_10: 1.14s -> 1.13s [-4.22%, +3.55%]
  • ✔️100_tpch_11: 84.2ms -> 83.5ms [-7.78%, +6.2%]
  • ✔️100_tpch_12: 1.11s -> 1.1s [-1.38%, +0.59%]
  • ✔️100_tpch_13: 333ms -> 349ms [-4.73%, +14.85%]
  • ✔️100_tpch_14: 1.03s -> 1.06s [-2.15%, +9%]
  • ✔️100_tpch_15: 1.13s -> 1.15s [-0.76%, +4.13%]
  • ✔️100_tpch_16: 125ms -> 124ms [-7.03%, +6.75%]
  • ✔️100_tpch_17: 1.08s -> 1.08s [-3.6%, +4.35%]
  • ✔️100_tpch_18: 1.12s -> 1.11s [-4.1%, +3.08%]
  • ✔️100_tpch_19: 1.2s -> 1.21s [-2.7%, +4.41%]
  • ✔️100_tpch_20: 1.08s -> 1.1s [-1.71%, +4.9%]
  • ✔️100_tpch_21: 2.25s -> 2.28s [-6.3%, +9.15%]
  • ✔️100_tpch_22: 175ms -> 180ms [-7.67%, +13.3%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@krlmlr krlmlr enabled auto-merge (squash) December 14, 2024 06:40
@krlmlr
Copy link
Member

krlmlr commented Dec 14, 2024

Thanks!

@github-actions GitHub Actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if c6e74b8 is merged into main:

  • ✔️001_tpch_01: 25.1ms -> 25ms [-4.72%, +3.75%]
  • ✔️001_tpch_02: 126ms -> 126ms [-1%, +1.58%]
  • ✔️001_tpch_03: 68.1ms -> 67.8ms [-2.53%, +1.52%]
  • ✔️001_tpch_04: 23.7ms -> 23.7ms [-1.64%, +1.94%]
  • ✔️001_tpch_05: 122ms -> 124ms [-0.2%, +2.28%]
  • ✔️001_tpch_06: 14.7ms -> 14.9ms [-0.78%, +2.53%]
  • ✔️001_tpch_07: 140ms -> 141ms [-0.49%, +2.09%]
  • ✔️001_tpch_08: 160ms -> 162ms [-0.16%, +1.75%]
  • ✔️001_tpch_09: 133ms -> 133ms [-0.52%, +1.66%]
  • ✔️001_tpch_10: 76.2ms -> 75.7ms [-2.18%, +0.73%]
  • ✔️001_tpch_11: 63.3ms -> 63.7ms [-0.72%, +2.16%]
  • ✔️001_tpch_12: 28.2ms -> 28.4ms [-0.51%, +1.9%]
  • ✔️001_tpch_13: 20ms -> 19.9ms [-1.64%, +0.93%]
  • 🚀001_tpch_14: 21.2ms -> 20.8ms [-2.83%, -0.71%]
  • ✔️001_tpch_15: 63.5ms -> 63.4ms [-1.91%, +1.79%]
  • ✔️001_tpch_16: 65.8ms -> 65.4ms [-2.1%, +0.91%]
  • ✔️001_tpch_17: 26.8ms -> 26.9ms [-0.27%, +1.47%]
  • ✔️001_tpch_18: 23.4ms -> 23.3ms [-2.11%, +1.3%]
  • ✔️001_tpch_19: 127ms -> 128ms [-0.67%, +1.85%]
  • ✔️001_tpch_20: 77.5ms -> 77.5ms [-1.54%, +1.61%]
  • ✔️001_tpch_21: 179ms -> 179ms [-1.25%, +1.3%]
  • ✔️001_tpch_22: 128ms -> 128ms [-1.35%, +1.07%]
  • ✔️010_tpch_01: 87.7ms -> 84.7ms [-10.74%, +3.9%]
  • ✔️010_tpch_02: 72.4ms -> 72.4ms [-2.49%, +2.47%]
  • ✔️010_tpch_03: 65.1ms -> 65.1ms [-1.31%, +1.18%]
  • ✔️010_tpch_04: 47ms -> 46.6ms [-2.71%, +0.85%]
  • ✔️010_tpch_05: 95.7ms -> 97ms [-0.12%, +2.69%]
  • ✔️010_tpch_06: 36.2ms -> 35.9ms [-6.09%, +4.42%]
  • ✔️010_tpch_07: 113ms -> 112ms [-3.48%, +1.33%]
  • ✔️010_tpch_08: 133ms -> 134ms [-0.21%, +1.13%]
  • ✔️010_tpch_09: 122ms -> 121ms [-2.31%, +1.39%]
  • ✔️010_tpch_10: 80.9ms -> 80.8ms [-1.99%, +1.79%]
  • ✔️010_tpch_11: 38ms -> 38ms [-2.47%, +2.28%]
  • ✔️010_tpch_12: 61.7ms -> 61ms [-3.3%, +1.16%]
  • ✔️010_tpch_13: 52.6ms -> 53.3ms [-1.13%, +4%]
  • ✔️010_tpch_14: 41.6ms -> 41.4ms [-2.31%, +1.54%]
  • ✔️010_tpch_15: 59.5ms -> 57.3ms [-10.1%, +2.71%]
  • ✔️010_tpch_16: 45.8ms -> 45.7ms [-5.65%, +5.03%]
  • ✔️010_tpch_17: 57.2ms -> 57ms [-3.84%, +3.14%]
  • ✔️010_tpch_18: 57ms -> 55.5ms [-7.8%, +2.46%]
  • ✔️010_tpch_19: 119ms -> 120ms [-0.1%, +2.98%]
  • ✔️010_tpch_20: 72.6ms -> 71.8ms [-5.67%, +3.32%]
  • ✔️010_tpch_21: 389ms -> 390ms [-0.84%, +1.12%]
  • ✔️010_tpch_22: 77.3ms -> 78.8ms [-0.96%, +4.95%]
  • ✔️100_tpch_01: 1.22s -> 1.23s [-1.45%, +2.56%]
  • ❗🐌100_tpch_02: 125ms -> 128ms [+2.21%, +3.49%]
  • ✔️100_tpch_03: 1.06s -> 1.08s [-1.03%, +4.1%]
  • ✔️100_tpch_04: 1.04s -> 1.04s [-2.2%, +2.8%]
  • ✔️100_tpch_05: 1.16s -> 1.15s [-3.14%, +1.61%]
  • ✔️100_tpch_06: 1.04s -> 1.03s [-6.12%, +4.19%]
  • ✔️100_tpch_07: 1.17s -> 1.17s [-5.23%, +5.36%]
  • ✔️100_tpch_08: 1.2s -> 1.19s [-4.78%, +2.76%]
  • ✔️100_tpch_09: 1.29s -> 1.31s [-2.05%, +5.61%]
  • ✔️100_tpch_10: 1.14s -> 1.15s [-3.42%, +3.83%]
  • ✔️100_tpch_11: 90.2ms -> 90.8ms [-32.31%, +33.53%]
  • ✔️100_tpch_12: 1.12s -> 1.14s [-3.19%, +5.89%]
  • ✔️100_tpch_13: 318ms -> 326ms [-0.99%, +6.36%]
  • ✔️100_tpch_14: 1.02s -> 1.05s [-0.4%, +5.04%]
  • ✔️100_tpch_15: 1.14s -> 1.13s [-3.82%, +2.25%]
  • ✔️100_tpch_16: 124ms -> 126ms [-3.8%, +7.34%]
  • ✔️100_tpch_17: 1.11s -> 1.1s [-5.51%, +3.7%]
  • ✔️100_tpch_18: 1.15s -> 1.15s [-0.41%, +1.7%]
  • ❗🐌100_tpch_19: 1.2s -> 1.22s [+0.34%, +2.92%]
  • ✔️100_tpch_20: 1.08s -> 1.08s [-8.45%, +8.71%]
  • ✔️100_tpch_21: 2.23s -> 2.22s [-4.55%, +3.34%]
  • ✔️100_tpch_22: 177ms -> 173ms [-9.33%, +5.8%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@krlmlr krlmlr changed the title feat: improve error message when getting an invalid .data feat: improve as_duckplyr_df() error message for invalid .data Dec 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 62158a5 is merged into main:

  • 🚀001_tpch_01: 27ms -> 25.7ms [-8.84%, -0.84%]
  • ✔️001_tpch_02: 139ms -> 139ms [-0.76%, +1.83%]
  • ❗🐌001_tpch_03: 73.7ms -> 74.8ms [+0.15%, +2.78%]
  • ✔️001_tpch_04: 25.2ms -> 25.1ms [-1.76%, +1.58%]
  • ✔️001_tpch_05: 132ms -> 131ms [-1.59%, +0.93%]
  • ✔️001_tpch_06: 16.3ms -> 16.4ms [-2%, +2.75%]
  • ✔️001_tpch_07: 145ms -> 146ms [-1.73%, +2.39%]
  • ✔️001_tpch_08: 157ms -> 157ms [-1.46%, +0.95%]
  • ✔️001_tpch_09: 130ms -> 129ms [-2.06%, +0.69%]
  • ✔️001_tpch_10: 74ms -> 74ms [-1.46%, +1.44%]
  • ✔️001_tpch_11: 62.6ms -> 61.9ms [-2.85%, +0.46%]
  • ✔️001_tpch_12: 28.3ms -> 28.3ms [-0.85%, +1.29%]
  • ✔️001_tpch_13: 19.7ms -> 20.2ms [-0.75%, +5.4%]
  • ✔️001_tpch_14: 21ms -> 20.9ms [-1.73%, +0.89%]
  • ✔️001_tpch_15: 61.9ms -> 62.6ms [-0.84%, +3.15%]
  • ✔️001_tpch_16: 64ms -> 64.3ms [-0.53%, +1.72%]
  • ✔️001_tpch_17: 26.9ms -> 27ms [-0.79%, +1.54%]
  • ✔️001_tpch_18: 23.1ms -> 22.8ms [-3.4%, +0.5%]
  • ✔️001_tpch_19: 126ms -> 127ms [-0.14%, +1.47%]
  • ✔️001_tpch_20: 76.6ms -> 77.3ms [-1.13%, +2.9%]
  • ✔️001_tpch_21: 171ms -> 169ms [-2.67%, +0.17%]
  • ✔️001_tpch_22: 123ms -> 124ms [-0.21%, +1.91%]
  • ✔️010_tpch_01: 82ms -> 85.1ms [-3.72%, +11.42%]
  • ✔️010_tpch_02: 71.1ms -> 71.7ms [-1.52%, +3.07%]
  • ✔️010_tpch_03: 63.8ms -> 65.1ms [-2.99%, +7.14%]
  • ✔️010_tpch_04: 46.9ms -> 46.4ms [-5.16%, +3.05%]
  • ✔️010_tpch_05: 96.1ms -> 94.9ms [-6.23%, +3.58%]
  • ✔️010_tpch_06: 35.1ms -> 37.4ms [-0.8%, +13.77%]
  • ✔️010_tpch_07: 110ms -> 112ms [-1.05%, +3.04%]
  • ✔️010_tpch_08: 132ms -> 132ms [-1.86%, +1.19%]
  • ✔️010_tpch_09: 120ms -> 122ms [-1.08%, +3.36%]
  • ✔️010_tpch_10: 79.2ms -> 78.9ms [-2.14%, +1.47%]
  • ✔️010_tpch_11: 38ms -> 39ms [-1.44%, +6.57%]
  • ✔️010_tpch_12: 60.6ms -> 61.4ms [-0.83%, +3.39%]
  • ✔️010_tpch_13: 52.5ms -> 52.4ms [-1.7%, +1.24%]
  • ✔️010_tpch_14: 40.4ms -> 40.5ms [-0.94%, +1.39%]
  • ❗🐌010_tpch_15: 55.1ms -> 59.8ms [+2.13%, +14.94%]
  • ✔️010_tpch_16: 44.7ms -> 43.7ms [-4.97%, +0.46%]
  • ✔️010_tpch_17: 57ms -> 57.2ms [-1.95%, +2.56%]
  • ✔️010_tpch_18: 56ms -> 58.1ms [-1.8%, +9.01%]
  • ✔️010_tpch_19: 121ms -> 120ms [-4.65%, +2.1%]
  • ✔️010_tpch_20: 71.4ms -> 70.6ms [-4.07%, +1.94%]
  • ✔️010_tpch_21: 377ms -> 376ms [-1.94%, +1.01%]
  • ✔️010_tpch_22: 78.1ms -> 79ms [-1.18%, +3.64%]
  • ✔️100_tpch_01: 1.18s -> 1.21s [-2.12%, +7.01%]
  • ✔️100_tpch_02: 126ms -> 124ms [-2.87%, +0.36%]
  • ✔️100_tpch_03: 1.06s -> 1.06s [-3.52%, +3.67%]
  • ✔️100_tpch_04: 1.04s -> 1.02s [-3.83%, +0.64%]
  • ✔️100_tpch_05: 1.15s -> 1.16s [-1.96%, +3.42%]
  • 🚀100_tpch_06: 1s -> 982ms [-3.56%, -0.11%]
  • ✔️100_tpch_07: 1.11s -> 1.12s [-4.43%, +6.21%]
  • ✔️100_tpch_08: 1.14s -> 1.16s [-1.69%, +4.85%]
  • ✔️100_tpch_09: 1.24s -> 1.23s [-5.09%, +3.66%]
  • ✔️100_tpch_10: 1.09s -> 1.09s [-2.15%, +2.94%]
  • ✔️100_tpch_11: 92.1ms -> 87ms [-37.5%, +26.33%]
  • ✔️100_tpch_12: 1.08s -> 1.07s [-3.9%, +1.93%]
  • ✔️100_tpch_13: 311ms -> 312ms [-7.9%, +8.67%]
  • ✔️100_tpch_14: 1.01s -> 1s [-2.02%, +0.89%]
  • ✔️100_tpch_15: 1.08s -> 1.08s [-2.36%, +1.87%]
  • ✔️100_tpch_16: 123ms -> 123ms [-3.47%, +2.9%]
  • ✔️100_tpch_17: 1.04s -> 1.05s [-1.84%, +3.07%]
  • ✔️100_tpch_18: 1.08s -> 1.08s [-3.67%, +3.2%]
  • ✔️100_tpch_19: 1.17s -> 1.17s [-2.87%, +2.1%]
  • ✔️100_tpch_20: 1.05s -> 1.06s [-1.13%, +2.6%]
  • ✔️100_tpch_21: 2.22s -> 2.19s [-4.9%, +1.62%]
  • ✔️100_tpch_22: 173ms -> 178ms [-8.38%, +14.1%]

Further explanation regarding interpretation and methodology can be found in the documentation.

@krlmlr krlmlr merged commit cd83469 into tidyverse:main Dec 14, 2024
30 checks passed
@github-actions GitHub Actions
Copy link
Contributor

This is how benchmark results would change (along with a 95% confidence interval in relative change) if cc277ed is merged into main:

  • ✔️001_tpch_01: 25.6ms -> 25.3ms [-5.41%, +2.66%]
  • ✔️001_tpch_02: 133ms -> 133ms [-1.02%, +0.75%]
  • ✔️001_tpch_03: 70.6ms -> 70.4ms [-1.48%, +0.91%]
  • ✔️001_tpch_04: 24.4ms -> 24.3ms [-2.04%, +1.24%]
  • ✔️001_tpch_05: 129ms -> 128ms [-1.49%, +0.58%]
  • 🚀001_tpch_06: 15.8ms -> 15.5ms [-3.81%, -0.01%]
  • ✔️001_tpch_07: 146ms -> 146ms [-1.47%, +0.32%]
  • ✔️001_tpch_08: 167ms -> 167ms [-1.57%, +0.74%]
  • ✔️001_tpch_09: 139ms -> 138ms [-1.11%, +0.84%]
  • ✔️001_tpch_10: 80ms -> 79.6ms [-2.02%, +1.07%]
  • ✔️001_tpch_11: 67.7ms -> 67.8ms [-1.02%, +1.38%]
  • ✔️001_tpch_12: 29.7ms -> 29.6ms [-2.66%, +2.12%]
  • ✔️001_tpch_13: 21.1ms -> 20.8ms [-3.64%, +0.8%]
  • ✔️001_tpch_14: 22ms -> 22ms [-2.11%, +2.17%]
  • ✔️001_tpch_15: 67.1ms -> 66.9ms [-1.56%, +0.9%]
  • ✔️001_tpch_16: 68.1ms -> 68.8ms [-0.49%, +2.46%]
  • ❗🐌001_tpch_17: 28ms -> 28.8ms [+0.42%, +5.03%]
  • ✔️001_tpch_18: 24.3ms -> 24.3ms [-2.96%, +2.85%]
  • ✔️001_tpch_19: 137ms -> 136ms [-1.83%, +1.1%]
  • ✔️001_tpch_20: 81.8ms -> 82.7ms [-0.13%, +2.22%]
  • ✔️001_tpch_21: 184ms -> 184ms [-0.9%, +1.46%]
  • ✔️001_tpch_22: 133ms -> 133ms [-1.05%, +0.69%]
  • ✔️010_tpch_01: 83.8ms -> 87.3ms [-2.66%, +11.04%]
  • ✔️010_tpch_02: 74.1ms -> 74.5ms [-2.81%, +3.9%]
  • ✔️010_tpch_03: 68.2ms -> 67.6ms [-4.74%, +2.8%]
  • ✔️010_tpch_04: 48.6ms -> 47.8ms [-3.58%, +0.5%]
  • ✔️010_tpch_05: 99.1ms -> 100ms [-1.51%, +4.29%]
  • ✔️010_tpch_06: 36.7ms -> 36ms [-7.03%, +3.1%]
  • ✔️010_tpch_07: 115ms -> 116ms [-1.61%, +4.03%]
  • ✔️010_tpch_08: 137ms -> 139ms [-1.45%, +3.99%]
  • ✔️010_tpch_09: 125ms -> 126ms [-2.75%, +3.2%]
  • ✔️010_tpch_10: 82.5ms -> 83ms [-2.36%, +3.59%]
  • ✔️010_tpch_11: 39.7ms -> 40.6ms [-1.51%, +6.15%]
  • ✔️010_tpch_12: 63ms -> 62.3ms [-3.44%, +1.23%]
  • ✔️010_tpch_13: 54.6ms -> 56.5ms [-5.32%, +12.43%]
  • ✔️010_tpch_14: 41.9ms -> 42ms [-1.3%, +1.56%]
  • ✔️010_tpch_15: 60.3ms -> 60ms [-5.96%, +4.94%]
  • ✔️010_tpch_16: 46.4ms -> 46.5ms [-1.78%, +1.86%]
  • ✔️010_tpch_17: 60ms -> 59.4ms [-4.5%, +2.31%]
  • ✔️010_tpch_18: 57.5ms -> 58.5ms [-4.86%, +8.29%]
  • ✔️010_tpch_19: 121ms -> 121ms [-0.97%, +0.98%]
  • ✔️010_tpch_20: 73.3ms -> 72.1ms [-4.7%, +1.44%]
  • ✔️010_tpch_21: 399ms -> 397ms [-2.51%, +1.58%]
  • ✔️010_tpch_22: 79.6ms -> 80.9ms [-1.77%, +5.08%]
  • ✔️100_tpch_01: 1.26s -> 1.25s [-6.46%, +5.64%]
  • ✔️100_tpch_02: 129ms -> 129ms [-5.2%, +4.82%]
  • ✔️100_tpch_03: 1.12s -> 1.12s [-1.06%, +1.57%]
  • ✔️100_tpch_04: 1.1s -> 1.09s [-2.82%, +1.11%]
  • ✔️100_tpch_05: 1.22s -> 1.22s [-3.71%, +3.3%]
  • ✔️100_tpch_06: 1.03s -> 1.04s [-0.62%, +2.76%]
  • ✔️100_tpch_07: 1.15s -> 1.17s [-0.95%, +3.01%]
  • ✔️100_tpch_08: 1.19s -> 1.19s [-3.77%, +3.85%]
  • ✔️100_tpch_09: 1.29s -> 1.28s [-5.2%, +4.03%]
  • ✔️100_tpch_10: 1.15s -> 1.14s [-4.16%, +2.21%]
  • ✔️100_tpch_11: 84.8ms -> 85.6ms [-5.2%, +7.12%]
  • ✔️100_tpch_12: 1.12s -> 1.12s [-1.65%, +1.82%]
  • ✔️100_tpch_13: 340ms -> 329ms [-8.06%, +1.41%]
  • ✔️100_tpch_14: 1.05s -> 1.06s [-0.39%, +2.19%]
  • ✔️100_tpch_15: 1.14s -> 1.15s [-2.15%, +3.51%]
  • ✔️100_tpch_16: 127ms -> 130ms [-5.67%, +9.83%]
  • ✔️100_tpch_17: 1.1s -> 1.11s [-1.01%, +2.44%]
  • ✔️100_tpch_18: 1.14s -> 1.15s [-1.36%, +3.67%]
  • ✔️100_tpch_19: 1.22s -> 1.21s [-2.68%, +1.45%]
  • ✔️100_tpch_20: 1.11s -> 1.11s [-2.54%, +1.91%]
  • ✔️100_tpch_21: 2.28s -> 2.27s [-2.04%, +1.6%]
  • ✔️100_tpch_22: 182ms -> 175ms [-8.1%, +0.43%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krlmlr krlmlr krlmlr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maelle @krlmlr