Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fall back to dplyr when passing multiple with joins #323

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Nov 4, 2024

No description provided.

@krlmlr krlmlr enabled auto-merge November 4, 2024 20:09
@krlmlr krlmlr added this pull request to the merge queue Nov 4, 2024
@krlmlr krlmlr changed the title feat: Error on multiple with joins feat: Fall back to dplyr when passing multiple with joins Nov 4, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 04a7889 is merged into main:

  • ✔️001_tpch_01: 25.6ms -> 25.4ms [-4.47%, +2.91%]
  • ✔️001_tpch_02: 136ms -> 136ms [-1.28%, +0.84%]
  • ✔️001_tpch_03: 73.4ms -> 73.9ms [-0.74%, +1.96%]
  • ✔️001_tpch_04: 26ms -> 26ms [-2%, +2.18%]
  • ✔️001_tpch_05: 132ms -> 132ms [-0.96%, +1.04%]
  • ✔️001_tpch_06: 16.2ms -> 16ms [-4.36%, +2.1%]
  • ✔️001_tpch_07: 142ms -> 142ms [-1.12%, +1.67%]
  • ✔️001_tpch_08: 164ms -> 164ms [-1.25%, +1.28%]
  • ✔️001_tpch_09: 131ms -> 131ms [-1.9%, +0.99%]
  • ❗🐌001_tpch_10: 76.1ms -> 140ms [+82.72%, +85.59%]
  • ✔️001_tpch_11: 65.5ms -> 64.5ms [-3.44%, +0.57%]
  • ✔️001_tpch_12: 59.1ms -> 59.6ms [-0.99%, +2.53%]
  • 🚀001_tpch_13: 20.1ms -> 19.7ms [-3.23%, -0.24%]
  • ✔️001_tpch_14: 21.4ms -> 21.4ms [-1.68%, +1.78%]
  • ✔️001_tpch_15: 64ms -> 63.6ms [-2.03%, +0.86%]
  • ✔️001_tpch_16: 64.9ms -> 65.1ms [-0.69%, +1.19%]
  • ✔️001_tpch_17: 27.1ms -> 27.3ms [-0.38%, +1.39%]
  • ✔️001_tpch_18: 23.3ms -> 23.4ms [-1.66%, +2.42%]
  • ✔️001_tpch_19: 131ms -> 132ms [-1.14%, +1.77%]
  • ✔️001_tpch_20: 78.8ms -> 79.3ms [-1.05%, +2.31%]
  • ✔️001_tpch_21: 177ms -> 178ms [-1.4%, +2.37%]
  • ✔️001_tpch_22: 125ms -> 126ms [-0.39%, +1.78%]
  • ✔️010_tpch_01: 85.9ms -> 84.1ms [-5.42%, +1.12%]
  • ✔️010_tpch_02: 78.2ms -> 76ms [-5.94%, +0.38%]
  • ✔️010_tpch_03: 69.8ms -> 70.2ms [-1.38%, +2.72%]
  • ✔️010_tpch_04: 51.8ms -> 51.5ms [-2.18%, +1.19%]
  • ✔️010_tpch_05: 100ms -> 99.8ms [-2.47%, +1.47%]
  • ✔️010_tpch_06: 37.8ms -> 37.2ms [-7.21%, +3.99%]
  • ✔️010_tpch_07: 119ms -> 119ms [-1.62%, +1.37%]
  • ✔️010_tpch_08: 140ms -> 141ms [-1.86%, +3.01%]
  • ✔️010_tpch_09: 123ms -> 122ms [-2.01%, +0.71%]
  • ✔️010_tpch_10: 88.8ms -> 88.1ms [-2.27%, +0.73%]
  • ✔️010_tpch_11: 41.2ms -> 41.4ms [-2.89%, +4.16%]
  • ✔️010_tpch_12: 67ms -> 63.9ms [-10.86%, +1.54%]
  • ✔️010_tpch_13: 54.5ms -> 54.6ms [-1.5%, +2.03%]
  • ✔️010_tpch_14: 44ms -> 43ms [-4.72%, +0.34%]
  • ✔️010_tpch_15: 59.4ms -> 62.8ms [-0.07%, +11.43%]
  • ✔️010_tpch_16: 47.1ms -> 47.5ms [-1.15%, +2.93%]
  • ✔️010_tpch_17: 61ms -> 59.4ms [-7.9%, +2.84%]
  • ✔️010_tpch_18: 59.9ms -> 58.6ms [-9.14%, +4.9%]
  • ✔️010_tpch_19: 126ms -> 127ms [-0.43%, +1.26%]
  • ✔️010_tpch_20: 78.2ms -> 78.1ms [-5.39%, +5.22%]
  • ✔️010_tpch_21: 442ms -> 451ms [-0.97%, +4.89%]
  • ✔️010_tpch_22: 81.1ms -> 80.8ms [-3.74%, +2.83%]
  • ✔️100_tpch_01: 1.18s -> 1.18s [-2.55%, +1.85%]
  • ✔️100_tpch_02: 123ms -> 122ms [-1.77%, +0.48%]
  • ✔️100_tpch_03: 1.09s -> 1.09s [-4.1%, +4.25%]
  • ✔️100_tpch_04: 1.09s -> 1.07s [-8.12%, +3.39%]
  • ✔️100_tpch_05: 1.21s -> 1.21s [-5.95%, +6.31%]
  • ✔️100_tpch_06: 1.01s -> 1.01s [-1.25%, +1.56%]
  • ✔️100_tpch_07: 1.14s -> 1.14s [-0.86%, +1.21%]
  • ✔️100_tpch_08: 1.19s -> 1.19s [-3.2%, +2.98%]
  • ✔️100_tpch_09: 1.29s -> 1.3s [-4.78%, +6.53%]
  • ✔️100_tpch_10: 1.14s -> 1.13s [-3.46%, +2.27%]
  • ✔️100_tpch_11: 82.7ms -> 82ms [-1.75%, +0.08%]
  • ✔️100_tpch_12: 1.12s -> 1.11s [-4.6%, +3.59%]
  • 🚀100_tpch_13: 350ms -> 335ms [-5.39%, -2.79%]
  • ✔️100_tpch_14: 1.04s -> 1.03s [-4.39%, +3.04%]
  • ✔️100_tpch_15: 1.14s -> 1.13s [-2.52%, +1.29%]
  • ✔️100_tpch_16: 125ms -> 123ms [-6.85%, +3.08%]
  • ✔️100_tpch_17: 1.09s -> 1.1s [-1.82%, +4.49%]
  • ✔️100_tpch_18: 1.12s -> 1.11s [-3.06%, +1.22%]
  • ✔️100_tpch_19: 1.22s -> 1.23s [-1.93%, +4.37%]
  • ✔️100_tpch_20: 1.11s -> 1.12s [-0.73%, +1.78%]
  • ✔️100_tpch_21: 2.27s -> 2.29s [-4.72%, +6.06%]
  • ❗🐌100_tpch_22: 172ms -> 187ms [+0.86%, +17.3%]

Further explanation regarding interpretation and methodology can be found in the documentation.

Merged via the queue into main with commit 4ac1708 Nov 4, 2024
7 checks passed
@krlmlr krlmlr deleted the f-join-multiple branch November 4, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant